Skip to content

Conversation

@doki23
Copy link
Contributor

@doki23 doki23 commented Feb 25, 2022

Which issue does this PR close?

close #1614

@alamb
Copy link
Contributor

alamb commented Mar 1, 2022

cc @tustvold

@alamb alamb added the api change Changes the API exposed to users of the crate label Mar 1, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @doki23

@alamb
Copy link
Contributor

alamb commented Mar 1, 2022

@doki23 I think the clippy failures have been fixed on master -- can you possible merge this branch to master (aka something like git merge apache/master so that we can get a clean CI run?

@doki23
Copy link
Contributor Author

doki23 commented Mar 2, 2022

@doki23 I think the clippy failures have been fixed on master -- can you possible merge this branch to master (aka something like git merge apache/master so that we can get a clean CI run?

No problem

Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb
Copy link
Contributor

alamb commented Mar 2, 2022

Thanks again @doki23 !

@alamb alamb merged commit 3c1252d into apache:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Sync from SendableRecordBatchStream

3 participants