fix: Add AWS environment variable checks for S3 tests #17519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2010YOUY01
reviewed
Sep 13, 2025
github-actions
bot
added
the
development-process
Weijun-H
force-pushed
the
17458-local-cli-s3-test-fail
branch
from
fc5577c to
848a7a1
Compare
github-actions
bot
removed
the
development-process
Weijun-H
force-pushed
the
17458-local-cli-s3-test-fail
branch
from
848a7a1 to
7a58221
Compare
2010YOUY01
approved these changes
Sep 13, 2025
Contributor
2010YOUY01
left a comment
2010YOUY01
left a comment
There was a problem hiding this comment.
Thank you! I've tested it locally.
Member
Author
|
Thanks @2010YOUY01 for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-clitests fails locally #17458Rationale for this change
Skip related tests if the AWS envs is not set.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No