-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[VARIANT] Add support for the json_to_variant API #7783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 38 commits
87b438d
a946ac6
bca3b81
339e880
fe798c3
882d3a7
3c18fdf
67a83fe
c9aa519
dede88d
fa3befc
38bac59
cd530ee
57b3eb0
71b7d6f
031c916
d4fc876
c41af4e
ecaf557
4abc598
0842ef8
94531af
28d0012
e2788f5
3178449
0455685
cc0b66e
d2a7516
a29b5c3
7f23cf5
50f4b25
560e430
3249d93
07d5688
af937ac
388f188
7407776
3b42d91
43d6ea5
e9deda9
eb11890
3531540
ea5b573
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! Example showing how to convert Variant values to JSON | ||
|
|
||
| use parquet_variant::{ | ||
| json_to_variant, variant_to_json, variant_to_json_string, variant_to_json_value, VariantBuilder, | ||
| }; | ||
|
|
||
| fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
| let person_string = "{\"name\":\"Alice\", \"age\":30, ".to_string() | ||
| + "\"email\":\"[email protected]\", \"is_active\": true, \"score\": 95.7," | ||
| + "\"additional_info\": null}"; | ||
|
|
||
| let mut variant_builder = VariantBuilder::new(); | ||
| json_to_variant(&person_string, &mut variant_builder)?; | ||
|
|
||
| let (metadata, value) = variant_builder.finish(); | ||
|
|
||
| let variant = parquet_variant::Variant::try_new(&metadata, &value)?; | ||
|
|
||
| let json_result = variant_to_json_string(&variant)?; | ||
| let json_value = variant_to_json_value(&variant)?; | ||
| let pretty_json = serde_json::to_string_pretty(&json_value)?; | ||
| println!("{pretty_json}"); | ||
|
|
||
| let mut buffer = Vec::new(); | ||
| variant_to_json(&mut buffer, &variant)?; | ||
| let buffer_result = String::from_utf8(buffer)?; | ||
| assert_eq!(json_result, "{\"additional_info\":null,\"age\":30,".to_string() + | ||
| "\"email\":\"[email protected]\",\"is_active\":true,\"name\":\"Alice\",\"score\":95.7}"); | ||
| assert_eq!(json_result, buffer_result); | ||
| assert_eq!(json_result, serde_json::to_string(&json_value)?); | ||
|
|
||
| Ok(()) | ||
| } | ||
alamb marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,149 @@ | ||||||||||||||
| // Licensed to the Apache Software Foundation (ASF) under one | ||||||||||||||
| // or more contributor license agreements. See the NOTICE file | ||||||||||||||
| // distributed with this work for additional information | ||||||||||||||
| // regarding copyright ownership. The ASF licenses this file | ||||||||||||||
| // to you under the Apache License, Version 2.0 (the | ||||||||||||||
| // "License"); you may not use this file except in compliance | ||||||||||||||
| // with the License. You may obtain a copy of the License at | ||||||||||||||
| // | ||||||||||||||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||||
| // | ||||||||||||||
| // Unless required by applicable law or agreed to in writing, | ||||||||||||||
| // software distributed under the License is distributed on an | ||||||||||||||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||||||||||||||
| // KIND, either express or implied. See the License for the | ||||||||||||||
| // specific language governing permissions and limitations | ||||||||||||||
| // under the License. | ||||||||||||||
|
|
||||||||||||||
| //! Module for parsing JSON strings as Variant | ||||||||||||||
|
|
||||||||||||||
| use crate::{ListBuilder, ObjectBuilder, Variant, VariantBuilder, VariantBuilderExt}; | ||||||||||||||
| use arrow_schema::ArrowError; | ||||||||||||||
| use serde_json::{Number, Value}; | ||||||||||||||
|
|
||||||||||||||
| /// Converts a JSON string to Variant using [`VariantBuilder`]. The resulting `value` and `metadata` | ||||||||||||||
| /// buffers can be extracted using `builder.finish()` | ||||||||||||||
| /// | ||||||||||||||
| /// # Arguments | ||||||||||||||
| /// * `json` - The JSON string to parse as Variant. | ||||||||||||||
| /// * `variant_builder` - Object of type `VariantBuilder` used to build the vatiant from the JSON | ||||||||||||||
| /// string | ||||||||||||||
| /// | ||||||||||||||
| /// # Returns | ||||||||||||||
| /// | ||||||||||||||
| /// * `Ok(())` if successful | ||||||||||||||
| /// * `Err` with error details if the conversion fails | ||||||||||||||
| /// | ||||||||||||||
| /// ```rust | ||||||||||||||
| /// # use parquet_variant::{ | ||||||||||||||
| /// json_to_variant, variant_to_json, variant_to_json_string, variant_to_json_value, VariantBuilder | ||||||||||||||
| /// }; | ||||||||||||||
| /// | ||||||||||||||
| /// let mut variant_builder = VariantBuilder::new(); | ||||||||||||||
| /// let person_string = "{\"name\":\"Alice\", \"age\":30, ".to_string() | ||||||||||||||
| /// + "\"email\":\"[email protected]\", \"is_active\": true, \"score\": 95.7," | ||||||||||||||
| /// + "\"additional_info\": null}"; | ||||||||||||||
| /// json_to_variant(&person_string, &mut variant_builder)?; | ||||||||||||||
| /// | ||||||||||||||
| /// let (metadata, value) = variant_builder.finish(); | ||||||||||||||
| /// | ||||||||||||||
| /// let variant = parquet_variant::Variant::try_new(&metadata, &value)?; | ||||||||||||||
| /// | ||||||||||||||
| /// let json_result = variant_to_json_string(&variant)?; | ||||||||||||||
| /// let json_value = variant_to_json_value(&variant)?; | ||||||||||||||
| /// | ||||||||||||||
| /// let mut buffer = Vec::new(); | ||||||||||||||
| /// variant_to_json(&mut buffer, &variant)?; | ||||||||||||||
| /// let buffer_result = String::from_utf8(buffer)?; | ||||||||||||||
| /// assert_eq!(json_result, "{\"additional_info\":null,\"age\":30,".to_string() + | ||||||||||||||
| /// "\"email\":\"[email protected]\",\"is_active\":true,\"name\":\"Alice\",\"score\":95.7}"); | ||||||||||||||
| /// assert_eq!(json_result, buffer_result); | ||||||||||||||
| /// assert_eq!(json_result, serde_json::to_string(&json_value)?); | ||||||||||||||
| /// # Ok::<(), Box<dyn std::error::Error>>(()) | ||||||||||||||
| /// ``` | ||||||||||||||
| pub fn json_to_variant(json: &str, builder: &mut VariantBuilder) -> Result<(), ArrowError> { | ||||||||||||||
| let json: Value = serde_json::from_str(json) | ||||||||||||||
| .map_err(|e| ArrowError::InvalidArgumentError(format!("JSON format error: {e}")))?; | ||||||||||||||
|
|
||||||||||||||
| build_json(&json, builder)?; | ||||||||||||||
| Ok(()) | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| fn build_json(json: &Value, builder: &mut VariantBuilder) -> Result<(), ArrowError> { | ||||||||||||||
| append_json(json, builder)?; | ||||||||||||||
| Ok(()) | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| fn variant_from_number<'a, 'b>(n: &Number) -> Result<Variant<'a, 'b>, ArrowError> { | ||||||||||||||
harshmotw-db marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||
| if let Some(i) = n.as_i64() { | ||||||||||||||
| // Find minimum Integer width to fit | ||||||||||||||
| if i as i8 as i64 == i { | ||||||||||||||
| Ok((i as i8).into()) | ||||||||||||||
| } else if i as i16 as i64 == i { | ||||||||||||||
| Ok((i as i16).into()) | ||||||||||||||
| } else if i as i32 as i64 == i { | ||||||||||||||
| Ok((i as i32).into()) | ||||||||||||||
| } else { | ||||||||||||||
| Ok(i.into()) | ||||||||||||||
| } | ||||||||||||||
| } else { | ||||||||||||||
| // Todo: Try decimal once we implement custom JSON parsing where we have access to strings | ||||||||||||||
| // Try double - currently json_to_variant does not produce decimal | ||||||||||||||
| match n.as_f64() { | ||||||||||||||
| Some(f) => return Ok(f.into()), | ||||||||||||||
| None => Err(ArrowError::InvalidArgumentError(format!( | ||||||||||||||
| "Failed to parse {} as number", | ||||||||||||||
| n.to_string() | ||||||||||||||
| ))), | ||||||||||||||
| }? | ||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| fn append_json(json: &Value, builder: &mut impl VariantBuilderExt) -> Result<(), ArrowError> { | ||||||||||||||
| match json { | ||||||||||||||
| Value::Null => builder.append_value(Variant::Null), | ||||||||||||||
| Value::Bool(b) => builder.append_value(*b), | ||||||||||||||
| Value::Number(n) => { | ||||||||||||||
| builder.append_value(variant_from_number(n)?); | ||||||||||||||
| } | ||||||||||||||
| Value::String(s) => builder.append_value(s.as_str()), | ||||||||||||||
| Value::Array(arr) => { | ||||||||||||||
| let mut list_builder = builder.new_list(); | ||||||||||||||
| for val in arr { | ||||||||||||||
| append_json(val, &mut list_builder)?; | ||||||||||||||
| } | ||||||||||||||
| list_builder.finish(); | ||||||||||||||
| } | ||||||||||||||
| Value::Object(obj) => { | ||||||||||||||
| let mut obj_builder = builder.new_object(); | ||||||||||||||
| for (key, value) in obj.iter() { | ||||||||||||||
| let mut field_builder = ObjectFieldBuilder { | ||||||||||||||
| key, | ||||||||||||||
| builder: &mut obj_builder, | ||||||||||||||
| }; | ||||||||||||||
| append_json(value, &mut field_builder)?; | ||||||||||||||
| } | ||||||||||||||
| obj_builder.finish().unwrap(); | ||||||||||||||
alamb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||
| } | ||||||||||||||
| }; | ||||||||||||||
| Ok(()) | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| struct ObjectFieldBuilder<'a, 'b, 'c> { | ||||||||||||||
| key: &'a str, | ||||||||||||||
| builder: &'b mut ObjectBuilder<'c, 'a>, | ||||||||||||||
|
||||||||||||||
| struct ObjectFieldBuilder<'a, 'b, 'c> { | |
| key: &'a str, | |
| builder: &'b mut ObjectBuilder<'c, 'a>, | |
| struct ObjectFieldBuilder<'m, 'v, 'r> { | |
| key: &'r str, | |
| builder: &'r mut ObjectBuilder<'m, 'v>, |
(here, 'r is the lifetime of the references used to construct the field builder)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to 's, 'o and 'v where 's is the lifetime of the 's is the lifetime of the string, 'o is the lifetime of [ObjectBuilder] and v is the lifetime of the variant buffers.
harshmotw-db marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,10 +33,12 @@ mod decoder; | |
| mod variant; | ||
| // TODO: dead code removal | ||
| mod builder; | ||
| mod from_json; | ||
| mod to_json; | ||
| #[allow(dead_code)] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This allow was bothering me , so here is a PR to clean it up: |
||
| mod utils; | ||
|
|
||
| pub use builder::*; | ||
| pub use from_json::json_to_variant; | ||
| pub use to_json::{variant_to_json, variant_to_json_string, variant_to_json_value}; | ||
| pub use variant::*; | ||
Uh oh!
There was an error while loading. Please reload this page.