Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
87b438d
add json_to_variant
harshmotw-db Jun 25, 2025
a946ac6
comment fix
harshmotw-db Jun 25, 2025
bca3b81
Added another sample buffer managger
harshmotw-db Jun 25, 2025
339e880
minor refactoring
harshmotw-db Jun 25, 2025
fe798c3
Merge branch 'main' of https://github.com/harshmotw-db/arrow-rs into …
harshmotw-db Jun 25, 2025
882d3a7
Merge branch 'main' of https://github.com/harshmotw-db/arrow-rs into …
harshmotw-db Jun 25, 2025
3c18fdf
incorporated new changes
harshmotw-db Jun 25, 2025
67a83fe
minor changes
harshmotw-db Jun 26, 2025
c9aa519
Merge branch 'main' of https://github.com/harshmotw-db/arrow-rs into …
harshmotw-db Jun 26, 2025
dede88d
test fix based on recent commit
harshmotw-db Jun 26, 2025
fa3befc
constant fix
harshmotw-db Jun 26, 2025
38bac59
fix
harshmotw-db Jun 26, 2025
cd530ee
addressed comments
harshmotw-db Jun 26, 2025
57b3eb0
fix
harshmotw-db Jun 26, 2025
71b7d6f
fixed VariantBufferManager
harshmotw-db Jun 26, 2025
031c916
deduped a bit of code
harshmotw-db Jun 26, 2025
d4fc876
deduplicated code
harshmotw-db Jun 26, 2025
c41af4e
moved serde code out of variant.rs
harshmotw-db Jun 26, 2025
ecaf557
incorporated Ryan's latest comments
harshmotw-db Jun 26, 2025
4abc598
add more object tests
harshmotw-db Jun 26, 2025
0842ef8
fix
harshmotw-db Jun 26, 2025
94531af
doc fix
harshmotw-db Jun 26, 2025
28d0012
Merge branch 'main' into harsh-motwani_data/from_json
harshmotw-db Jun 27, 2025
e2788f5
Removed dependency on VariantBufferManager and leave that to later
harshmotw-db Jun 27, 2025
3178449
Merge branch 'harsh-motwani_data/from_json' of https://github.com/har…
harshmotw-db Jun 27, 2025
0455685
fix
harshmotw-db Jun 27, 2025
cc0b66e
fix
harshmotw-db Jun 30, 2025
d2a7516
resolved test comment
harshmotw-db Jun 30, 2025
a29b5c3
fixed more comments
harshmotw-db Jun 30, 2025
7f23cf5
fix decimal to string
harshmotw-db Jul 1, 2025
50f4b25
fmt and clippy
harshmotw-db Jul 1, 2025
560e430
fix
harshmotw-db Jul 1, 2025
3249d93
Merge remote-tracking branch 'apache/main' into harsh-motwani_data/fr…
alamb Jul 1, 2025
07d5688
clippy
alamb Jul 1, 2025
af937ac
Split tests into separate functions
alamb Jul 1, 2025
388f188
partially removed decimal dependency
harshmotw-db Jul 2, 2025
7407776
merge
harshmotw-db Jul 2, 2025
3b42d91
removed decimal type from variant json parsing
harshmotw-db Jul 2, 2025
43d6ea5
comment fix
harshmotw-db Jul 2, 2025
e9deda9
refined lifetimes
harshmotw-db Jul 3, 2025
eb11890
Fix clippy, remove unused dependency
alamb Jul 3, 2025
3531540
Merge remote-tracking branch 'apache/main' into harsh-motwani_data/fr…
alamb Jul 3, 2025
ea5b573
Update parquet-variant/src/from_json.rs
alamb Jul 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions parquet-variant/examples/variant_from_json_examples.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Example showing how to convert Variant values to JSON

use parquet_variant::{
json_to_variant, variant_to_json, variant_to_json_string, variant_to_json_value, VariantBuilder,
};

fn main() -> Result<(), Box<dyn std::error::Error>> {
let person_string = "{\"name\":\"Alice\", \"age\":30, ".to_string()
+ "\"email\":\"[email protected]\", \"is_active\": true, \"score\": 95.7,"
+ "\"additional_info\": null}";

let mut variant_builder = VariantBuilder::new();
json_to_variant(&person_string, &mut variant_builder)?;

let (metadata, value) = variant_builder.finish();

let variant = parquet_variant::Variant::try_new(&metadata, &value)?;

let json_result = variant_to_json_string(&variant)?;
let json_value = variant_to_json_value(&variant)?;
let pretty_json = serde_json::to_string_pretty(&json_value)?;
println!("{pretty_json}");

let mut buffer = Vec::new();
variant_to_json(&mut buffer, &variant)?;
let buffer_result = String::from_utf8(buffer)?;
assert_eq!(json_result, "{\"additional_info\":null,\"age\":30,".to_string() +
"\"email\":\"[email protected]\",\"is_active\":true,\"name\":\"Alice\",\"score\":95.7}");
assert_eq!(json_result, buffer_result);
assert_eq!(json_result, serde_json::to_string(&json_value)?);

Ok(())
}
38 changes: 38 additions & 0 deletions parquet-variant/src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,44 @@ impl<'a, 'b> ObjectBuilder<'a, 'b> {
}
}

/// Trait that abstracts functionality from Variant fconstruction implementations, namely
/// `VariantBuilder`, `ListBuilder` and `ObjectFieldBuilder` to minimize code duplication.
pub(crate) trait VariantBuilderExt<'m, 'v> {
fn append_value(&mut self, value: impl Into<Variant<'m, 'v>>);

fn new_list(&mut self) -> ListBuilder;

fn new_object(&mut self) -> ObjectBuilder;
}

impl<'m, 'v> VariantBuilderExt<'m, 'v> for ListBuilder<'_> {
fn append_value(&mut self, value: impl Into<Variant<'m, 'v>>) {
self.append_value(value);
}

fn new_list(&mut self) -> ListBuilder {
self.new_list()
}

fn new_object(&mut self) -> ObjectBuilder {
self.new_object()
}
}

impl<'m, 'v> VariantBuilderExt<'m, 'v> for VariantBuilder {
fn append_value(&mut self, value: impl Into<Variant<'m, 'v>>) {
self.append_value(value);
}

fn new_list(&mut self) -> ListBuilder {
self.new_list()
}

fn new_object(&mut self) -> ObjectBuilder {
self.new_object()
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
151 changes: 151 additions & 0 deletions parquet-variant/src/from_json.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,151 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Module for parsing JSON strings as Variant

use crate::{ListBuilder, ObjectBuilder, Variant, VariantBuilder, VariantBuilderExt};
use arrow_schema::ArrowError;
use serde_json::{Number, Value};

/// Converts a JSON string to Variant using [`VariantBuilder`]. The resulting `value` and `metadata`
/// buffers can be extracted using `builder.finish()`
///
/// # Arguments
/// * `json` - The JSON string to parse as Variant.
/// * `variant_builder` - Object of type `VariantBuilder` used to build the vatiant from the JSON
/// string
///
/// # Returns
///
/// * `Ok(())` if successful
/// * `Err` with error details if the conversion fails
///
/// ```rust
/// # use parquet_variant::{
/// json_to_variant, variant_to_json, variant_to_json_string, variant_to_json_value, VariantBuilder
/// };
///
/// let mut variant_builder = VariantBuilder::new();
/// let person_string = "{\"name\":\"Alice\", \"age\":30, ".to_string()
/// + "\"email\":\"[email protected]\", \"is_active\": true, \"score\": 95.7,"
/// + "\"additional_info\": null}";
/// json_to_variant(&person_string, &mut variant_builder)?;
///
/// let (metadata, value) = variant_builder.finish();
///
/// let variant = parquet_variant::Variant::try_new(&metadata, &value)?;
///
/// let json_result = variant_to_json_string(&variant)?;
/// let json_value = variant_to_json_value(&variant)?;
///
/// let mut buffer = Vec::new();
/// variant_to_json(&mut buffer, &variant)?;
/// let buffer_result = String::from_utf8(buffer)?;
/// assert_eq!(json_result, "{\"additional_info\":null,\"age\":30,".to_string() +
/// "\"email\":\"[email protected]\",\"is_active\":true,\"name\":\"Alice\",\"score\":95.7}");
/// assert_eq!(json_result, buffer_result);
/// assert_eq!(json_result, serde_json::to_string(&json_value)?);
/// # Ok::<(), Box<dyn std::error::Error>>(())
/// ```
pub fn json_to_variant(json: &str, builder: &mut VariantBuilder) -> Result<(), ArrowError> {
let json: Value = serde_json::from_str(json)
.map_err(|e| ArrowError::InvalidArgumentError(format!("JSON format error: {e}")))?;

build_json(&json, builder)?;
Ok(())
}

fn build_json(json: &Value, builder: &mut VariantBuilder) -> Result<(), ArrowError> {
append_json(json, builder)?;
Ok(())
}

fn variant_from_number<'m, 'v>(n: &Number) -> Result<Variant<'m, 'v>, ArrowError> {
if let Some(i) = n.as_i64() {
// Find minimum Integer width to fit
if i as i8 as i64 == i {
Ok((i as i8).into())
} else if i as i16 as i64 == i {
Ok((i as i16).into())
} else if i as i32 as i64 == i {
Ok((i as i32).into())
} else {
Ok(i.into())
}
} else {
// Todo: Try decimal once we implement custom JSON parsing where we have access to strings
// Try double - currently json_to_variant does not produce decimal
match n.as_f64() {
Some(f) => return Ok(f.into()),
None => Err(ArrowError::InvalidArgumentError(format!(
"Failed to parse {n} as number",
))),
}?
}
}

fn append_json<'m, 'v>(
json: &'v Value,
builder: &mut impl VariantBuilderExt<'m, 'v>,
) -> Result<(), ArrowError> {
match json {
Value::Null => builder.append_value(Variant::Null),
Value::Bool(b) => builder.append_value(*b),
Value::Number(n) => {
builder.append_value(variant_from_number(n)?);
}
Value::String(s) => builder.append_value(s.as_str()),
Value::Array(arr) => {
let mut list_builder = builder.new_list();
for val in arr {
append_json(val, &mut list_builder)?;
}
list_builder.finish();
}
Value::Object(obj) => {
let mut obj_builder = builder.new_object();
for (key, value) in obj.iter() {
let mut field_builder = ObjectFieldBuilder {
key,
builder: &mut obj_builder,
};
append_json(value, &mut field_builder)?;
}
obj_builder.finish()?;
}
};
Ok(())
}

struct ObjectFieldBuilder<'s, 'o, 'v> {
key: &'s str,
builder: &'o mut ObjectBuilder<'v, 's>,
}

impl<'m, 'v> VariantBuilderExt<'m, 'v> for ObjectFieldBuilder<'_, '_, '_> {
fn append_value(&mut self, value: impl Into<Variant<'m, 'v>>) {
self.builder.insert(self.key, value);
}

fn new_list(&mut self) -> ListBuilder {
self.builder.new_list(self.key)
}

fn new_object(&mut self) -> ObjectBuilder {
self.builder.new_object(self.key)
}
}
2 changes: 2 additions & 0 deletions parquet-variant/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@ mod decoder;
mod variant;
// TODO: dead code removal
mod builder;
mod from_json;
mod to_json;
#[allow(dead_code)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allow was bothering me , so here is a PR to clean it up:

mod utils;

pub use builder::*;
pub use from_json::json_to_variant;
pub use to_json::{variant_to_json, variant_to_json_string, variant_to_json_value};
pub use variant::*;
8 changes: 4 additions & 4 deletions parquet-variant/src/variant/decimal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ pub struct VariantDecimal4 {
}

impl VariantDecimal4 {
const MAX_PRECISION: u8 = 9;
const MAX_UNSCALED_VALUE: u32 = u32::pow(10, Self::MAX_PRECISION as u32) - 1;
pub(crate) const MAX_PRECISION: u8 = 9;
pub(crate) const MAX_UNSCALED_VALUE: u32 = u32::pow(10, Self::MAX_PRECISION as u32) - 1;

pub fn try_new(integer: i32, scale: u8) -> Result<Self, ArrowError> {
decimal_try_new!(integer, scale)
Expand Down Expand Up @@ -136,8 +136,8 @@ pub struct VariantDecimal8 {
}

impl VariantDecimal8 {
const MAX_PRECISION: u8 = 18;
const MAX_UNSCALED_VALUE: u64 = u64::pow(10, Self::MAX_PRECISION as u32) - 1;
pub(crate) const MAX_PRECISION: u8 = 18;
pub(crate) const MAX_UNSCALED_VALUE: u64 = u64::pow(10, Self::MAX_PRECISION as u32) - 1;

pub fn try_new(integer: i64, scale: u8) -> Result<Self, ArrowError> {
decimal_try_new!(integer, scale)
Expand Down
Loading
Loading