Add resize function for Dag Documentation #56344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyLee1224
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
Author
|
Should I modify Dag Note UI as well or save it to another PR? |
Contributor
Would be great and of course can be another PR. |
jscheffl
reviewed
Oct 2, 2025
airflow-core/src/airflow/ui/src/components/DisplayMarkdownButton.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
Update
resize_memorize.mp4 |
jscheffl
approved these changes
Oct 3, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the persistence extension!
Before merge, maybe a second pair of review eyes?
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
A few suggestions, tested locally and look great. Can't wait to see the same implemented for TI and DagRun notes.
airflow-core/src/airflow/ui/src/components/ui/ResizableWrapper.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/components/DisplayMarkdownButton.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/utils/usePersistentResizableState.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/utils/usePersistentResizableState.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
Follow up PR:Add resize function for Dag Note |
bbovenzi
approved these changes
Oct 8, 2025
kaxil
pushed a commit
that referenced
this pull request
Oct 16, 2025
* feat: Add dialog resize function * feat: Memorize resize state * refactor: replace inline style and use useLocalStorage * fix: remove redundent style * refactor: optimize state management (cherry picked from commit aab7f16)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* feat: Add dialog resize function * feat: Memorize resize state * refactor: replace inline style and use useLocalStorage * fix: remove redundent style * refactor: optimize state management
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* feat: Add dialog resize function * feat: Memorize resize state * refactor: replace inline style and use useLocalStorage * fix: remove redundent style * refactor: optimize state management
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
* feat: Add dialog resize function * feat: Memorize resize state * refactor: replace inline style and use useLocalStorage * fix: remove redundent style * refactor: optimize state management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
closes: #56325
Changes
react-resizabledependency to handle the resizing logic.maxConstraints={[1200, 800]},minConstraints={[512, 600]}brand.mutedto align with Dag Note UI designScreenshots
Before
After
resize.mp4
Default resize indicator
Styled resize indicator
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.