Skip to content

v3.0: svm: remove NativeLoader-owned rent assert (backport of #9574)#9582

Merged
2501babe merged 1 commit intov3.0from
mergify/bp/v3.0/pr-9574
Dec 17, 2025
Merged

v3.0: svm: remove NativeLoader-owned rent assert (backport of #9574)#9582
2501babe merged 1 commit intov3.0from
mergify/bp/v3.0/pr-9574

Conversation

@mergify
Copy link

@mergify mergify bot commented Dec 16, 2025

Problem

TransactionAccountStateInfo::new() contains a debug assert that a writable account is not owned by NativeLoader. this is overly general, as the condition we actually value is that a reserved account key is not writable

Summary of Changes

remove it. we could check against ReservedAccountKeys here instead but this would require pulling it from Bank through svm. since it is only is debug assert and the condition itself is checked in sanitization, this does not seem necessary


This is an automatic backport of pull request #9574 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner December 16, 2025 16:27
@mergify mergify bot added the conflicts label Dec 16, 2025
@mergify
Copy link
Author

mergify bot commented Dec 16, 2025

Cherry-pick of 1a7bbc5 has failed:

On branch mergify/bp/v3.0/pr-9574
Your branch is up to date with 'origin/v3.0'.

You are currently cherry-picking commit 1a7bbc56f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   svm/src/transaction_account_state_info.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@2501babe 2501babe force-pushed the mergify/bp/v3.0/pr-9574 branch from c727cc1 to d1d6490 Compare December 16, 2025 17:11
@2501babe 2501babe force-pushed the mergify/bp/v3.0/pr-9574 branch from d1d6490 to 9e4d8a8 Compare December 17, 2025 10:58
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.4%. Comparing base (f5a29bf) to head (9e4d8a8).
⚠️ Report is 1 commits behind head on v3.0.

Additional details and impacted files
@@            Coverage Diff            @@
##             v3.0    #9582     +/-   ##
=========================================
- Coverage    83.4%    83.4%   -0.1%     
=========================================
  Files         810      810             
  Lines      366263   366262      -1     
=========================================
- Hits       305738   305718     -20     
- Misses      60525    60544     +19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@2501babe 2501babe requested a review from Lichtso December 17, 2025 11:54
@2501babe 2501babe added the automerge automerge Merge this Pull Request automatically once CI passes label Dec 17, 2025
@2501babe 2501babe merged commit b856935 into v3.0 Dec 17, 2025
44 checks passed
@2501babe 2501babe deleted the mergify/bp/v3.0/pr-9574 branch December 17, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants