v3.0: svm: remove NativeLoader-owned rent assert (backport of #9574)#9582
Merged
v3.0: svm: remove NativeLoader-owned rent assert (backport of #9574)#9582
Conversation
Author
|
Cherry-pick of 1a7bbc5 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
c727cc1 to
d1d6490
Compare
t-nelson
approved these changes
Dec 16, 2025
(cherry picked from commit 1a7bbc5)
d1d6490 to
9e4d8a8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.0 #9582 +/- ##
=========================================
- Coverage 83.4% 83.4% -0.1%
=========================================
Files 810 810
Lines 366263 366262 -1
=========================================
- Hits 305738 305718 -20
- Misses 60525 60544 +19 🚀 New features to boost your workflow:
|
Lichtso
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TransactionAccountStateInfo::new()contains a debug assert that a writable account is not owned byNativeLoader. this is overly general, as the condition we actually value is that a reserved account key is not writableSummary of Changes
remove it. we could check against
ReservedAccountKeyshere instead but this would require pulling it fromBankthrough svm. since it is only is debug assert and the condition itself is checked in sanitization, this does not seem necessaryThis is an automatic backport of pull request #9574 done by Mergify.