svm: remove NativeLoader-owned rent assert#9574
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9574 +/- ##
=========================================
- Coverage 82.5% 82.5% -0.1%
=========================================
Files 901 901
Lines 323326 323325 -1
=========================================
- Hits 267033 267018 -15
- Misses 56293 56307 +14 🚀 New features to boost your workflow:
|
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 1a7bbc5) # Conflicts: # svm/src/transaction_account_state_info.rs
(cherry picked from commit 1a7bbc5)
(cherry picked from commit 1a7bbc5)
(cherry picked from commit 1a7bbc5)
(cherry picked from commit 1a7bbc5)
Problem
TransactionAccountStateInfo::new()contains a debug assert that a writable account is not owned byNativeLoader. this is overly general, as the condition we actually value is that a reserved account key is not writableSummary of Changes
remove it. we could check against
ReservedAccountKeyshere instead but this would require pulling it fromBankthrough svm. since it is only is debug assert and the condition itself is checked in sanitization, this does not seem necessary