Skip to content

svm: remove NativeLoader-owned rent assert#9574

Merged
2501babe merged 1 commit intoanza-xyz:masterfrom
2501babe:20251216_nativeassert
Dec 16, 2025
Merged

svm: remove NativeLoader-owned rent assert#9574
2501babe merged 1 commit intoanza-xyz:masterfrom
2501babe:20251216_nativeassert

Conversation

@2501babe
Copy link
Member

@2501babe 2501babe commented Dec 16, 2025

Problem

TransactionAccountStateInfo::new() contains a debug assert that a writable account is not owned by NativeLoader. this is overly general, as the condition we actually value is that a reserved account key is not writable

Summary of Changes

remove it. we could check against ReservedAccountKeys here instead but this would require pulling it from Bank through svm. since it is only is debug assert and the condition itself is checked in sanitization, this does not seem necessary

@2501babe 2501babe self-assigned this Dec 16, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.5%. Comparing base (d16bb56) to head (da6a000).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #9574     +/-   ##
=========================================
- Coverage    82.5%    82.5%   -0.1%     
=========================================
  Files         901      901             
  Lines      323326   323325      -1     
=========================================
- Hits       267033   267018     -15     
- Misses      56293    56307     +14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@2501babe 2501babe marked this pull request as ready for review December 16, 2025 12:14
@2501babe 2501babe requested a review from a team as a code owner December 16, 2025 12:14
@2501babe 2501babe requested a review from Lichtso December 16, 2025 12:14
@2501babe 2501babe added v3.1 Backport to v3.1 branch v3.0 Backport to v3.0 branch labels Dec 16, 2025
@2501babe 2501babe added this pull request to the merge queue Dec 16, 2025
@mergify
Copy link

mergify bot commented Dec 16, 2025

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link

mergify bot commented Dec 16, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Merged via the queue into anza-xyz:master with commit 1a7bbc5 Dec 16, 2025
49 checks passed
@2501babe 2501babe deleted the 20251216_nativeassert branch December 16, 2025 16:26
mergify bot pushed a commit that referenced this pull request Dec 16, 2025
(cherry picked from commit 1a7bbc5)

# Conflicts:
#	svm/src/transaction_account_state_info.rs
mergify bot pushed a commit that referenced this pull request Dec 16, 2025
2501babe added a commit that referenced this pull request Dec 16, 2025
2501babe added a commit that referenced this pull request Dec 17, 2025
2501babe added a commit that referenced this pull request Dec 17, 2025
2501babe added a commit that referenced this pull request Dec 17, 2025
…9582)

svm: remove NativeLoader-owned rent assert (#9574)

(cherry picked from commit 1a7bbc5)

Co-authored-by: hana <81144685+2501babe@users.noreply.github.com>
2501babe added a commit that referenced this pull request Dec 17, 2025
…9583)

svm: remove NativeLoader-owned rent assert (#9574)

(cherry picked from commit 1a7bbc5)

Co-authored-by: hana <81144685+2501babe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3.0 Backport to v3.0 branch v3.1 Backport to v3.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants