v3.1: fix(repair): keep processing batch in process_replay_updates by using continue (backport of #9339)#9375
Merged
AshwinSekar merged 1 commit intov3.1from Dec 3, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.1 #9375 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 865 865
Lines 375946 375981 +35
=======================================
+ Hits 313033 313072 +39
+ Misses 62913 62909 -4 🚀 New features to boost your workflow:
|
t-nelson
approved these changes
Dec 3, 2025
AshwinSekar
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_replay_updates used return to skip non-actionable updates, which aborted processing of the remaining items in the same try_iter batch. Replace the early returns with continue so we only skip the current update and still handle the rest. This aligns with similar patterns in replay_stage. Added a regression test to ensure a skipped update (slot <= root) does not prevent processing a subsequent actionable update in the same call.
This is an automatic backport of pull request #9339 done by Mergify.