fix(repair): keep processing batch in process_replay_updates by using continue#9339
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9339 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 893 893
Lines 320978 321005 +27
=========================================
+ Hits 265170 265178 +8
- Misses 55808 55827 +19 🚀 New features to boost your workflow:
|
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
process_replay_updates used return to skip non-actionable updates, which aborted processing of the remaining items in the same try_iter batch. Replace the early returns with continue so we only skip the current update and still handle the rest. This aligns with similar patterns in replay_stage. Added a regression test to ensure a skipped update (slot <= root) does not prevent processing a subsequent actionable update in the same call.