Skip to content

fix(repair): keep processing batch in process_replay_updates by using continue#9339

Merged
AshwinSekar merged 1 commit intoanza-xyz:masterfrom
Forostovec:fix/ancestor-hashes-continue-batch-processing
Dec 1, 2025
Merged

fix(repair): keep processing batch in process_replay_updates by using continue#9339
AshwinSekar merged 1 commit intoanza-xyz:masterfrom
Forostovec:fix/ancestor-hashes-continue-batch-processing

Conversation

@Forostovec
Copy link

process_replay_updates used return to skip non-actionable updates, which aborted processing of the remaining items in the same try_iter batch. Replace the early returns with continue so we only skip the current update and still handle the rest. This aligns with similar patterns in replay_stage. Added a regression test to ensure a skipped update (slot <= root) does not prevent processing a subsequent actionable update in the same call.

Copy link

@AshwinSekar AshwinSekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks for fixing!

@AshwinSekar AshwinSekar added the CI Pull Request is ready to enter CI label Dec 1, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Dec 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.6%. Comparing base (5b59b18) to head (3f2da7d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #9339     +/-   ##
=========================================
- Coverage    82.6%    82.6%   -0.1%     
=========================================
  Files         893      893             
  Lines      320978   321005     +27     
=========================================
+ Hits       265170   265178      +8     
- Misses      55808    55827     +19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshwinSekar AshwinSekar enabled auto-merge December 1, 2025 15:50
@AshwinSekar AshwinSekar added this pull request to the merge queue Dec 1, 2025
Merged via the queue into anza-xyz:master with commit 70300f2 Dec 1, 2025
51 checks passed
@AshwinSekar AshwinSekar added v3.0 Backport to v3.0 branch v3.1 Backport to v3.1 branch labels Dec 2, 2025
@mergify
Copy link

mergify bot commented Dec 2, 2025

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link

mergify bot commented Dec 2, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Dec 2, 2025
mergify bot pushed a commit that referenced this pull request Dec 2, 2025
AshwinSekar pushed a commit that referenced this pull request Dec 3, 2025
… using continue (backport of #9339) (#9375)

fix(repair): keep processing batch in process_replay_updates by using continue (#9339)

(cherry picked from commit 70300f2)

Co-authored-by: Forostovec <ilonaforostovec22@gmail.com>
AshwinSekar pushed a commit that referenced this pull request Dec 3, 2025
… using continue (backport of #9339) (#9374)

fix(repair): keep processing batch in process_replay_updates by using continue (#9339)

(cherry picked from commit 70300f2)

Co-authored-by: Forostovec <ilonaforostovec22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community need:merge-assist v3.0 Backport to v3.0 branch v3.1 Backport to v3.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants