Skip to content

v3.0: receive_and_buffer with external_worker (backport of #9212)#9266

Merged
tao-stones merged 2 commits intov3.0from
mergify/bp/v3.0/pr-9212
Dec 1, 2025
Merged

v3.0: receive_and_buffer with external_worker (backport of #9212)#9266
tao-stones merged 2 commits intov3.0from
mergify/bp/v3.0/pr-9212

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 25, 2025

Problem

  • receive_and_buffer uses root bank for both ALT loading and vote-only checking,
  • External worker uses receive_and_buffer code to translate transaction,

Summary of Changes

  • use working bank for vote-only checking, root for ALT loading
  • update External worker accordingly

Fixes #


This is an automatic backport of pull request #9212 done by [Mergify](https://mergify.com).

(cherry picked from commit f3a5a32)

# Conflicts:
#	core/src/banking_stage/consume_worker.rs
#	core/src/banking_stage/transaction_scheduler/receive_and_buffer.rs
@mergify mergify bot added the conflicts label Nov 25, 2025
@mergify mergify bot requested a review from a team as a code owner November 25, 2025 00:00
@mergify mergify bot added the conflicts label Nov 25, 2025
@mergify
Copy link
Author

mergify bot commented Nov 25, 2025

Cherry-pick of f3a5a32 has failed:

On branch mergify/bp/v3.0/pr-9212
Your branch is up to date with 'origin/v3.0'.

You are currently cherry-picking commit f3a5a32d1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/banking_stage/consume_worker.rs
	both modified:   core/src/banking_stage/transaction_scheduler/receive_and_buffer.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.4%. Comparing base (5a06890) to head (54ce715).

Additional details and impacted files
@@            Coverage Diff            @@
##             v3.0    #9266     +/-   ##
=========================================
- Coverage    83.4%    83.4%   -0.1%     
=========================================
  Files         810      810             
  Lines      366228   366228             
=========================================
- Hits       305683   305682      -1     
- Misses      60545    60546      +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tao-stones
Copy link

Backport note: not trivia backporting, the "external worker" code not exist in 3.0; simply picking the change for using working_bank for VO.

@t-nelson
Copy link

this one-liner is sufficient?

@tao-stones
Copy link

this one-liner is sufficient?

Yes, it's this one liner - use working bank for vote-only checking, while root for ALT loading is existing behavior.

Have to add additional parameter to function(s) in 3.1+

Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's this one liner - use working bank for vote-only checking, while root for ALT loading is existing behavior.

Have to add additional parameter to function(s) in 3.1+

take me back

@t-nelson
Copy link

@OliverNChalk mind providing sme review here too?

@OliverNChalk OliverNChalk self-requested a review December 1, 2025 16:43
@tao-stones tao-stones merged commit 6e6998c into v3.0 Dec 1, 2025
43 checks passed
@tao-stones tao-stones deleted the mergify/bp/v3.0/pr-9212 branch December 1, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants