Skip to content

receive_and_buffer with external_worker#9212

Merged
tao-stones merged 1 commit intoanza-xyz:masterfrom
tao-stones:chore/receive-and-buffer-transaction-view
Nov 24, 2025
Merged

receive_and_buffer with external_worker#9212
tao-stones merged 1 commit intoanza-xyz:masterfrom
tao-stones:chore/receive-and-buffer-transaction-view

Conversation

@tao-stones
Copy link

@tao-stones tao-stones commented Nov 21, 2025

Problem

  • receive_and_buffer uses root bank for both ALT loading and vote-only checking,
  • External worker uses receive_and_buffer code to translate transaction,

Summary of Changes

  • use working bank for vote-only checking, root for ALT loading
  • update External worker accordingly

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.6%. Comparing base (108e725) to head (7fcfae1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #9212     +/-   ##
=========================================
- Coverage    82.6%    82.6%   -0.1%     
=========================================
  Files         890      890             
  Lines      320852   320861      +9     
=========================================
- Hits       265305   265285     -20     
- Misses      55547    55576     +29     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tao-stones tao-stones marked this pull request as ready for review November 21, 2025 17:22
@t-nelson t-nelson requested a review from bw-solana November 21, 2025 17:44
@tao-stones tao-stones added v3.0 Backport to v3.0 branch v3.1 Backport to v3.1 branch labels Nov 21, 2025
@mergify
Copy link

mergify bot commented Nov 21, 2025

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link

mergify bot commented Nov 21, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@tao-stones tao-stones requested a review from t-nelson November 24, 2025 15:53
Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh

@tao-stones tao-stones added this pull request to the merge queue Nov 24, 2025
Merged via the queue into anza-xyz:master with commit f3a5a32 Nov 24, 2025
49 checks passed
@tao-stones tao-stones deleted the chore/receive-and-buffer-transaction-view branch November 24, 2025 23:59
mergify bot pushed a commit that referenced this pull request Nov 25, 2025
(cherry picked from commit f3a5a32)

# Conflicts:
#	core/src/banking_stage/consume_worker.rs
#	core/src/banking_stage/transaction_scheduler/receive_and_buffer.rs
mergify bot pushed a commit that referenced this pull request Nov 25, 2025
(cherry picked from commit f3a5a32)

# Conflicts:
#	core/src/banking_stage/consume_worker.rs
AvhiMaz pushed a commit to AvhiMaz/agave that referenced this pull request Nov 28, 2025
tao-stones added a commit that referenced this pull request Dec 1, 2025
)

* receive_and_buffer with external_worker (#9212)

(cherry picked from commit f3a5a32)

# Conflicts:
#	core/src/banking_stage/consume_worker.rs
#	core/src/banking_stage/transaction_scheduler/receive_and_buffer.rs

* fix merge conflicts

---------

Co-authored-by: Tao Zhu <82401714+tao-stones@users.noreply.github.com>
Co-authored-by: Tao Zhu <tao@anza.xyz>
tao-stones added a commit that referenced this pull request Dec 1, 2025
)

* receive_and_buffer with external_worker (#9212)

(cherry picked from commit f3a5a32)

# Conflicts:
#	core/src/banking_stage/consume_worker.rs

* fix merge conflicts

* fix: loading root_bank from SharableBank

---------

Co-authored-by: Tao Zhu <82401714+tao-stones@users.noreply.github.com>
Co-authored-by: Tao Zhu <tao@anza.xyz>
apfitzge added a commit to apfitzge/agave that referenced this pull request Jan 29, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 29, 2026
mergify bot pushed a commit that referenced this pull request Jan 29, 2026
This reverts commit f3a5a32.

(cherry picked from commit 01f1def)

# Conflicts:
#	core/src/banking_stage/consume_worker.rs
apfitzge added a commit that referenced this pull request Jan 29, 2026
apfitzge added a commit that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3.0 Backport to v3.0 branch v3.1 Backport to v3.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants