Skip to content

v3.1: runtime: Add test for epoch boundary (backport of #8838)#9149

Merged
vadorovsky merged 2 commits intov3.1from
mergify/bp/v3.1/pr-8838
Nov 27, 2025
Merged

v3.1: runtime: Add test for epoch boundary (backport of #8838)#9149
vadorovsky merged 2 commits intov3.1from
mergify/bp/v3.1/pr-8838

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 19, 2025

Add test that ensures correct values in Bank and PartitionedRewardsCalculation after crossing epoch boundary.


This is an automatic backport of pull request #8838 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner November 19, 2025 13:49
@mergify mergify bot added the conflicts label Nov 19, 2025
@mergify
Copy link
Author

mergify bot commented Nov 19, 2025

Cherry-pick of 30d8afd has failed:

On branch mergify/bp/v3.1/pr-8838
Your branch is up to date with 'origin/v3.1'.

You are currently cherry-picking commit 30d8afd32.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   runtime/src/bank/partitioned_epoch_rewards/mod.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   runtime/src/bank/partitioned_epoch_rewards/calculation.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@t-nelson
Copy link

@vadorovsky can you rebase when you fix conflicts here? need to pickup the version bump commit to pass sanity

@t-nelson
Copy link

@vadorovsky ping

@vadorovsky vadorovsky force-pushed the mergify/bp/v3.1/pr-8838 branch from edf4157 to a8773dd Compare November 25, 2025 11:50
@vadorovsky
Copy link
Member

Sorry for late reaction, done.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (8887656) to head (f1e6ae3).

Additional details and impacted files
@@           Coverage Diff            @@
##             v3.1    #9149    +/-   ##
========================================
  Coverage    83.2%    83.2%            
========================================
  Files         865      865            
  Lines      375625   375787   +162     
========================================
+ Hits       312710   312846   +136     
- Misses      62915    62941    +26     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

t-nelson
t-nelson previously approved these changes Nov 26, 2025
@t-nelson
Copy link

derp needs conflict resolution again

Add test that ensures correct values in `Bank` and
`PartitionedRewardsCalculation` after crossing epoch boundary.

(cherry picked from commit 30d8afd)
@vadorovsky
Copy link
Member

green again

@t-nelson
Copy link

@HaoranYi can you give sme review for this bp?

@vadorovsky vadorovsky merged commit 563f595 into v3.1 Nov 27, 2025
44 checks passed
@vadorovsky vadorovsky deleted the mergify/bp/v3.1/pr-8838 branch November 27, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants