Skip to content

runtime: Add test for epoch boundary#8838

Merged
vadorovsky merged 1 commit intoanza-xyz:masterfrom
vadorovsky:fix-epoch-boundary-test
Nov 4, 2025
Merged

runtime: Add test for epoch boundary#8838
vadorovsky merged 1 commit intoanza-xyz:masterfrom
vadorovsky:fix-epoch-boundary-test

Conversation

@vadorovsky
Copy link
Member

@vadorovsky vadorovsky commented Nov 2, 2025

Add test that ensures correct values in Bank and PartitionedRewardsCalculation after crossing epoch boundary.

@vadorovsky vadorovsky force-pushed the fix-epoch-boundary-test branch from 4bfe042 to 89efafd Compare November 2, 2025 09:55
@vadorovsky vadorovsky changed the title runtime: Assert only the capitalization diff in test_epoch_boundary runtime: Relax easily breakable assertions in test_epoch_boundary Nov 2, 2025
@alexpyattaev alexpyattaev self-requested a review November 2, 2025 10:08
@vadorovsky vadorovsky marked this pull request as ready for review November 2, 2025 10:14
alexpyattaev
alexpyattaev previously approved these changes Nov 2, 2025
Copy link

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (e1634f7) to head (485fa4d).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8838    +/-   ##
========================================
  Coverage    83.2%    83.2%            
========================================
  Files         863      863            
  Lines      373689   373851   +162     
========================================
+ Hits       310984   311183   +199     
+ Misses      62705    62668    -37     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vadorovsky vadorovsky marked this pull request as draft November 2, 2025 11:38
@vadorovsky
Copy link
Member Author

vadorovsky commented Nov 2, 2025

Putting this on hold, I'll submit a full relaxed test here once the revert gets merged. Ready for review.

@vadorovsky vadorovsky force-pushed the fix-epoch-boundary-test branch from 89efafd to 4056272 Compare November 3, 2025 09:35
@vadorovsky vadorovsky changed the title runtime: Relax easily breakable assertions in test_epoch_boundary runtime: Add test for epoch boundary Nov 3, 2025
@vadorovsky vadorovsky marked this pull request as ready for review November 3, 2025 09:56
@alexpyattaev
Copy link

The asserts look good, for the rest of the review I defer to the SMEs.

@alexpyattaev alexpyattaev removed their request for review November 3, 2025 10:13
HaoranYi
HaoranYi previously approved these changes Nov 4, 2025
Add test that ensures correct values in `Bank` and
`PartitionedRewardsCalculation` after crossing epoch boundary.
@vadorovsky vadorovsky added this pull request to the merge queue Nov 4, 2025
Merged via the queue into anza-xyz:master with commit 30d8afd Nov 4, 2025
44 checks passed
@vadorovsky vadorovsky deleted the fix-epoch-boundary-test branch November 4, 2025 20:18
@vadorovsky vadorovsky added the v3.1 Backport to v3.1 branch label Nov 19, 2025
@mergify
Copy link

mergify bot commented Nov 19, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Nov 19, 2025
Add test that ensures correct values in `Bank` and
`PartitionedRewardsCalculation` after crossing epoch boundary.

(cherry picked from commit 30d8afd)

# Conflicts:
#	runtime/src/bank/partitioned_epoch_rewards/calculation.rs
rustopian pushed a commit to rustopian/agave that referenced this pull request Nov 20, 2025
Add test that ensures correct values in `Bank` and
`PartitionedRewardsCalculation` after crossing epoch boundary.
vadorovsky added a commit to vadorovsky/agave that referenced this pull request Nov 25, 2025
Add test that ensures correct values in `Bank` and
`PartitionedRewardsCalculation` after crossing epoch boundary.

(cherry picked from commit 30d8afd)

# Conflicts:
#	runtime/src/bank/partitioned_epoch_rewards/calculation.rs
vadorovsky added a commit to vadorovsky/agave that referenced this pull request Nov 26, 2025
Add test that ensures correct values in `Bank` and
`PartitionedRewardsCalculation` after crossing epoch boundary.

(cherry picked from commit 30d8afd)
vadorovsky added a commit that referenced this pull request Nov 27, 2025
Add test that ensures correct values in `Bank` and
`PartitionedRewardsCalculation` after crossing epoch boundary.

(cherry picked from commit 30d8afd)

Co-authored-by: Michal R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3.1 Backport to v3.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants