Skip to content

fix: migrator secret escaping #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
germa89 merged 2 commits into from
Jun 16, 2025
Merged

fix: migrator secret escaping #4012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec56121
fix: secret escaping, PR title and not commenting when re-running
germa89 Jun 16, 2025
f4539d3
chore: adding changelog file 4012.fixed.md [dependabot-skip]
pyansys-ci-bot Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/migrator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ jobs:
if : ${{ env.CONTINUE == 'true' }}
uses: actions/github-script@v7
with:
github-token: ${{ secrets.PYANSYS_CI_BOT_TOKEN }}
github-token: "${{ secrets.PYANSYS_CI_BOT_TOKEN }}"
script: |
const prNumber = process.env.PR_NUMBER;
const prHeadBranch = process.env.PR_HEAD_BRANCH;
Expand Down Expand Up @@ -393,7 +393,7 @@ jobs:
debug: true,
head: prBaseBranch, // This is the branch we just created which becomes now the head of the PR, and the base (target) branch is the main branch.
base: 'main',
title: `chore: [migrated PR ${prNumber}] ${originalPR.title}`,
title: `migrated (PR ${prNumber}): ${originalPR.title}`,
body: `This PR is a mirror pull request created from [${originalPR.title}](https://github.com/ansys/pymapdl/pull/${originalPR.number}) to allow the code to access PyMAPDL CICD secrets.

Check the [original PR](https://github.com/ansys/pymapdl/pull/${originalPR.number}) made by @${originalPR.user.login} for more details.
Expand Down Expand Up @@ -444,7 +444,8 @@ jobs:
});

- name: Create comment about failed migration
if: ${{ failure() }}
# Not creating more failure comments if the workflow is retried
if: ${{ failure() && github.run_attempt == 1 }}
uses: actions/github-script@v7
with:
github-token: ${{ secrets.PYANSYS_CI_BOT_TOKEN }}
Expand Down
1 change: 1 addition & 0 deletions doc/changelog.d/4012.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix: migrator secret escaping
Loading