-
Notifications
You must be signed in to change notification settings - Fork 142
fix: migrator secret escaping #4012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR refines the GitHub Actions migrator workflow by properly escaping the CI token secret, updating the mirrored PR title format, and preventing duplicate failure comments on retries. Flow diagram for updated migrator workflow steps in GitHub Actionsflowchart TD
A[Start Migration Job] --> B[Use github-script with properly escaped secret token]
B --> C[Create mirrored PR with updated title format]
C --> D{Migration Success?}
D -- Yes --> E[End]
D -- No --> F{Is this the first run attempt?}
F -- Yes --> G[Create failure comment]
F -- No --> H[Skip failure comment]
G --> E
H --> E
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
Fix migrator secret escaping, PR title and not commenting when re-running
Issue linked
Related to failure to migrate #4009 however I am not sure this should fix it.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Fix secret escaping in the migrator workflow, standardize the migrated PR title format, and limit failure comments to the first run attempt.
CI: