Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 24, 2025

Description

Avoid state changes when raising exceptions in fixtures or tests.

Additionally continue the work started in #3758. I wanted to make this a different PR, but it is needed here.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner February 24, 2025 10:46
@germa89 germa89 self-assigned this Feb 24, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89
Copy link
Collaborator Author

germa89 commented Feb 24, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Feb 24, 2025
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Feb 24, 2025
@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.38%. Comparing base (2023420) to head (680a4c8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3760      +/-   ##
==========================================
+ Coverage   88.28%   88.38%   +0.09%     
==========================================
  Files         187      187              
  Lines       14713    14719       +6     
==========================================
+ Hits        12990    13010      +20     
+ Misses       1723     1709      -14     

@germa89 germa89 changed the title feat: adding changeproperty context manager feat: adding muted context manager Feb 24, 2025
@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) and removed CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Feb 24, 2025
@germa89 germa89 enabled auto-merge (squash) February 24, 2025 21:06
@germa89 germa89 disabled auto-merge February 24, 2025 21:06
@germa89 germa89 merged commit be6cbbf into main Feb 25, 2025
51 of 55 checks passed
@germa89 germa89 deleted the feat/adding-change-property-context-manager branch February 25, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related (improving, adding, etc) new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants