Skip to content

fix: Improve error handling in *GET method and enhance output logging #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
germa89 merged 19 commits into from
Feb 24, 2025
Merged

fix: Improve error handling in *GET method and enhance output logging #3758

germa89 merged 19 commits into from
Feb 24, 2025

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 21, 2025

Description

As the title. Make sure we do return a string from *GET if needed.

Issue linked

Close #3757

Checklist

@germa89 germa89 requested a review from a team as a code owner February 21, 2025 11:31
@ansys-reviewer-bot
Copy link
Contributor

ansys-reviewer-bot bot commented Feb 21, 2025

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Feb 21, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Feb 21, 2025

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Feb 21, 2025
pyansys-ci-bot and others added 18 commits February 21, 2025 11:32
@pyansys-ci-bot
chore: adding changelog file 3758.fixed.md [dependabot-skip]
f7cc8a3
@germa89
feat: adding timeout to get_lock
f68151e
@germa89
feat: adding tests
2a4ae01
@germa89
Merge branch 'fix/more-stable--get-command' of https://github.com/ans…
b1a74f1 
…ys/pymapdl into fix/more-stable--get-command
@germa89
fix: enhance output handling in *GET method to manage None values
93781d3
@germa89
feat: caching platform
be39a55
@germa89
feat: fix message
7b177f9
@germa89
refactor: update test functions to use consistent mapdl fixture
11ceed8
@germa89
test: see if the errors are coming from testing
319d132
@germa89
test: catching state change
9a38649
@germa89
fix: test
4b12bed
@germa89
fix: tests
318035c
@germa89
fix: remove duplicated code
5a7c218
@germa89
revert: revert "test: see if the errors are coming from testing"
fa24da4 
This reverts commit 319d132.
@germa89
fix: improve output handling in MapdlGrpc class by making "VALUE" str…
2ac1a4d 
…ipping optional
@germa89
test: reset _store_commands flag in test_get_non_interactive_mode
593183c
@germa89
test: add assertion to verify _store_commands flag is reset
1f1bac9
@germa89
fix: clean up test_args_pass by resetting mapdl control and deleting …
cc0401a 
…instance
@germa89 germa89 merged commit 2023420 into main Feb 24, 2025
46 of 47 checks passed
@germa89 germa89 deleted the fix/more-stable--get-command branch February 24, 2025 11:05
@germa89
Copy link
Collaborator Author

germa89 commented Feb 24, 2025

See also #3760 for more related info.

This was referenced Feb 24, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees

@germa89 germa89

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in *get

3 participants

@germa89 @pyansys-ci-bot