Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 17, 2025

Description

As the title. Avoiding issuing /POST1 before solving.

Issue linked

Close #3714

Checklist

@germa89 germa89 requested a review from a team as a code owner February 17, 2025 16:08
@germa89 germa89 self-assigned this Feb 17, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Feb 17, 2025
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (b39d487) to head (d3853a3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3747      +/-   ##
==========================================
- Coverage   88.27%   88.25%   -0.02%     
==========================================
  Files         187      187              
  Lines       14705    14708       +3     
==========================================
  Hits        12981    12981              
- Misses       1724     1727       +3     

@germa89
Copy link
Collaborator Author

germa89 commented Feb 17, 2025

Almost all runs went well at the first try. Only local:v25.1-ubuntu which seemed stuck since it didn't move from test_disp_plot_subselection test. I did try to run that test order in local container and it did pass

Checking second run.

--EDIT--
Second run hit 5% under 3 minutes (so the previous stuck tests didnt fail)

@germa89
Copy link
Collaborator Author

germa89 commented Feb 17, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit cac8a0a into main Feb 17, 2025
51 of 53 checks passed
@germa89 germa89 deleted the fix/xpl-error-when-solving-on-a-previous-read-model branch February 17, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CICD testing fails on XPL module

3 participants