Skip to content

phpThumb/FD1 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whattheslime merged 2 commits into from
Mar 11, 2025
Merged

phpThumb/FD1 #201

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcefadd
phpthumb/FD1
mcdruid Nov 26, 2024
d4ed546
remove lower bound of version range
mcdruid Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions gadgetchains/phpThumb/FD/1/chain.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace GadgetChain\phpThumb;

class FD1 extends \PHPGGC\GadgetChain\FileDelete
{
public static $version = 'v1.7.12 <= v1.7.22';
Copy link
Copy Markdown
Contributor

@jvoisin jvoisin Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static $version = 'v1.7.12 <= v1.7.22';
public static $version = '<= v1.7.22';

Since you said it would work on all version before this one.

Copy link
Copy Markdown
Contributor Author

@mcdruid mcdruid Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we could do that.

Somewhat strangely it seems that v1.7.12 is the first release, at least in the project's current incarnation:

https://github.com/JamesHeinrich/phpThumb/tags

public static $vector = '__destruct';
public static $author = 'mcdruid';
public static $information = 'Fixed by https://github.com/JamesHeinrich/phpThumb/pull/226';

public function generate(array $parameters)
{
return new \phpthumb($parameters['remote_path']);
}
}
11 changes: 11 additions & 0 deletions gadgetchains/phpThumb/FD/1/gadgets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

class phpthumb
{
public $tempFilesToDelete = [];

public function __construct($tempFileToDelete) {
$this->tempFilesToDelete[] = $tempFileToDelete;
}

}