Merged
Conversation
jvoisin
reviewed
Nov 26, 2024
gadgetchains/phpThumb/FD/1/chain.php
Outdated
|
|
||
| class FD1 extends \PHPGGC\GadgetChain\FileDelete | ||
| { | ||
| public static $version = 'v1.7.12 <= v1.7.22'; |
Contributor
There was a problem hiding this comment.
Suggested change
| public static $version = 'v1.7.12 <= v1.7.22'; | |
| public static $version = '<= v1.7.22'; |
Since you said it would work on all version before this one.
Contributor
Author
There was a problem hiding this comment.
Yup, we could do that.
Somewhat strangely it seems that v1.7.12 is the first release, at least in the project's current incarnation:
https://github.com/JamesHeinrich/phpThumb/tags
Collaborator
|
Thanks for all your contributions; the gadget has been added to the project. However, please note that the fix you proposed mitigates this gadget chain to prevent arbitrary file deletion but can still be used for other purposes. Please check the following comment: #205 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very simple FD gadget chain, which should work in all releases until the next.