This repository was archived by the owner on Feb 8, 2023. It is now read-only.
[release-1.9]: backport: fix a race condition #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to setup the travis CI, right? @starnop |
Collaborator
Author
|
@allencloud Yeah, we need change the branch of cri-tools to setup the travis CI. I will do that until this PR has been merged. |
|
LGTM |
|
@starnop could we add the travis-CI here before we merge? |
fuweid
reviewed
Oct 23, 2018
.travis.yml
Outdated
|
|
||
| go: | ||
| - 1.9.x | ||
| - 1.10.x |
There was a problem hiding this comment.
the change is ok. but we don't need to run it with go1.10. So just keep the change in the scope of fixing the data race.
starnop
force-pushed
the
race-condition
branch
from
c07662a to
39438de
Compare
|
|
starnop
force-pushed
the
race-condition
branch
from
39438de to
01dff3d
Compare
fuweid
changed the title
Signed-off-by: Lantao Liu <[email protected]>
starnop
force-pushed
the
race-condition
branch
from
01dff3d to
e48db0b
Compare
fuweid
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lantao Liu [email protected]
NOTE: cherry pick.