Skip to content

Conversation

@starnop
Copy link
Contributor

@starnop starnop commented Oct 22, 2018

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

as title described.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

None.

Ⅳ. Describe how to verify it

run the CI.

Ⅴ. Special notes for reviews

updated mainly for : alibaba-archive/cri-tools#3

@codecov
Copy link

codecov bot commented Oct 22, 2018

Codecov Report

Merging #2340 into master will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2340      +/-   ##
==========================================
+ Coverage   66.19%   66.61%   +0.41%     
==========================================
  Files         218      218              
  Lines       17674    17955     +281     
==========================================
+ Hits        11699    11960     +261     
- Misses       4609     4613       +4     
- Partials     1366     1382      +16
Flag Coverage Δ
#criv1alpha1test 31.87% <ø> (-0.44%) ⬇️
#criv1alpha2test 36.26% <ø> (?)
#integrationtest 40.5% <ø> (+0.03%) ⬆️
#nodee2etest 33.86% <ø> (+0.03%) ⬆️
#unittest 23.42% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 51.67% <0%> (-14.51%) ⬇️
ctrd/container.go 59.28% <0%> (-0.48%) ⬇️
daemon/mgr/container.go 59.21% <0%> (ø) ⬆️
cri/v1alpha1/cri.go 61.03% <0%> (+0.32%) ⬆️
daemon/containerio/container_io.go 75.95% <0%> (+1.09%) ⬆️
cri/stream/remotecommand/httpstream.go 46.63% <0%> (+3.1%) ⬆️
cri/v1alpha2/cri_utils.go 90.57% <0%> (+3.28%) ⬆️
daemon/containerio/cri_log_file.go 88.23% <0%> (+3.92%) ⬆️
daemon/mgr/container_storage.go 59.81% <0%> (+8.27%) ⬆️
storage/quota/prjquota.go 27.51% <0%> (+12.08%) ⬆️
... and 3 more

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Oct 22, 2018
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit e0392ba into AliyunContainerService:master Oct 23, 2018
@allencloud allencloud changed the title [bugfix]: update the branch of cri-tools has been updated bugfix: update the branch of cri-tools has been updated Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants