Adjusting canvas height based GenotypeTrack height#12
Open
snaheth wants to merge 145 commits intoakmorrow13:masterfrom
Open
Adjusting canvas height based GenotypeTrack height#12snaheth wants to merge 145 commits intoakmorrow13:masterfrom
snaheth wants to merge 145 commits intoakmorrow13:masterfrom
Conversation
…and Genotype.js constructors to take in objects instead
…atureDataSource-test.js file
…th RemoteRequest file
…and Genotype.js constructors to take in objects instead
fixed no data error for alignments and max rows for PileupTrack
…uest areas already in cache.
Variant fixes
# Conflicts: # src/main/sources/GA4GHDataSource.js
Update Feature Transparency Based on Score
akmorrow13
reviewed
Apr 12, 2017
| searchNode = ReactDOM.findDOMNode(searchNode).parentNode; | ||
| if (searchNode && searchNode.className && searchNode.className.split(' ') && searchNode.className.split(' ')[1]) { | ||
| let name = searchNode.className.split(' ')[1]; | ||
| if (name == GenotypeTrack.displayName) { |
Owner
There was a problem hiding this comment.
Did we decide to do anything about the PileupTrack?
Owner
There was a problem hiding this comment.
Can you comment this a little more so we know whats going on?
|
Can one of the admins verify this patch? |
Author
|
Fixed in the latest PR |
Owner
|
Sorry @snaheth , that was a test PR for some build testing and will not be merged. |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not using props on this one so we don't have to spread our code out over classes, as discussed