Update Feature Transparency Based on Score#11
Merged
akmorrow13 merged 1 commit intoakmorrow13:masterfrom Mar 6, 2017
Merged
Conversation
akmorrow13
reviewed
Mar 6, 2017
src/main/viz/FeatureTrack.js
Outdated
| ctx.lineWidth = 1; | ||
| ctx.fillStyle = 'black'; | ||
|
|
||
| var featureTransp = feature.score / 10; |
Owner
There was a problem hiding this comment.
make sure it is still visible when score is 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple fix.
You may see issues of the canvas rectangles stacked on top of each other. This is important because an opacity of an opacity is not accurate representation of the feature's score. We can look at this together if that's the case.