Skip to content

Change ollama embedding api #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2025
Merged

Change ollama embedding api #874

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c128545
change ollama embedding api
qbc2016 Oct 29, 2025
81d8c0d
update required version for ollama
qbc2016 Oct 30, 2025
3dbe569
clean code
DavdGao Oct 30, 2025
4dbfb45
remove gather
qbc2016 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/agentscope/embedding/_ollama_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,15 @@ async def __call__(
"Input text must be a list of strings or TextBlock dicts.",
)

dimensions = kwargs.pop("dimensions", self.dimensions)

kwargs = {
"input": gather_text,
"model": self.model_name,
"dimensions": dimensions,
**kwargs,
}

if self.embedding_cache:
cached_embeddings = await self.embedding_cache.retrieve(
identifier=kwargs,
Expand All @@ -83,22 +92,17 @@ async def __call__(
)

start_time = datetime.now()
response = await asyncio.gather(
*[
self.client.embeddings(self.model_name, _, **kwargs)
for _ in gather_text
],
)
response = await asyncio.gather(*[self.client.embed(**kwargs)])
time = (datetime.now() - start_time).total_seconds()

if self.embedding_cache:
await self.embedding_cache.store(
identifier=kwargs,
embeddings=[_.embedding for _ in response],
embeddings=[_.embeddings[0] for _ in response],
)

return EmbeddingResponse(
embeddings=[_.embedding for _ in response],
embeddings=[_.embeddings[0] for _ in response],
usage=EmbeddingUsage(
time=time,
),
Expand Down