Skip to content

Conversation

@qbc2016
Copy link
Member

@qbc2016 qbc2016 commented Oct 29, 2025

AgentScope Version

[The version of AgentScope you are working on, e.g. import agentscope; print(agentscope.__version__)]

Description

Since the original embeddings in ollama will be "Deprecated in favor of embed", we change it to embed, which supports the parameter dimensions

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with pre-commit run --all-files command
  • All tests are passing
  • Docstrings are in Google style
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@qbc2016 qbc2016 added Enhancement Enhance the existing functionalities Ready for Review labels Oct 29, 2025
Copy link
Member

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version of ollama dependency in pyproject.toml

Copy link
Member

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit 5f62604 into agentscope-ai:main Oct 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Enhance the existing functionalities Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants