Skip to content

hide annoying navigation buttons on android #4090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2019
Merged

hide annoying navigation buttons on android #4090

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b506ba9
hide annoying navigation buttons on android
VolodymyrBaydalka Mar 11, 2019
609a234
refactored to fit code convention
VolodymyrBaydalka Mar 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/scene/a-scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,7 @@ function requestFullscreen (canvas) {
canvas.webkitRequestFullscreen ||
canvas.mozRequestFullScreen || // The capitalized `S` is not a typo.
canvas.msRequestFullscreen;
requestFullscreen.apply(canvas);
requestFullscreen.apply(canvas, [{ navigationUI: "hide" }]); //hide annoying navigation buttons on android
Copy link
Member

@dmarcos dmarcos Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter failing (double quotes) and extra spaces. Update comment. See below:

// Hide navigation buttons on Android.
requestFullscreen.apply(canvas, [{navigationUI: 'hide'}]);

}

function exitFullscreen () {
Expand Down