hide annoying navigation buttons on android #4090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. A small change and it's good. |
dmarcos
reviewed
Mar 18, 2019
src/core/scene/a-scene.js
Outdated
| canvas.mozRequestFullScreen || // The capitalized `S` is not a typo. | ||
| canvas.msRequestFullscreen; | ||
| requestFullscreen.apply(canvas); | ||
| requestFullscreen.apply(canvas, [{ navigationUI: "hide" }]); //hide annoying navigation buttons on android |
Member
There was a problem hiding this comment.
Linter failing (double quotes) and extra spaces. Update comment. See below:
// Hide navigation buttons on Android.
requestFullscreen.apply(canvas, [{navigationUI: 'hide'}]);
Member
|
Awesome. thanks! Congrats on your first PR 🎆 |
ngokevin
pushed a commit
that referenced
this pull request
Apr 18, 2019
* hide annoying navigation buttons on android * refactored to fit code convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In fullscreen mode chrome for android keeps showing system navigation UI
Changes proposed: