Remove 'collada-model' component. #3866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm okay if the model examples aren't perfect color-wise, at least for this PR. |
|
Thanks @donmccurdy for staying on top. I'm good with deprecating now. This way it won't come as a surprise in 1.0.0. |
|
Thanks, could we merge #3757 first? It should be easier to keep the colors consistent for the examples I've touched here, once that is in. |
|
Ok, I think this is ready to go. |
|
Thanks! |
|
Hello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3793.
There are a few issues with this PR that should be discussed or resolved before merging.
Some scenes still require manual adjustment to colors, where glTF models are present alongsidematerialcolors and textures. Automatic adjustments are possible ([renderer] Add color management option, replacing gammaOutput. #3757) but may require some time to get right.Issues with conversion of thetree1.glbandtree2.glbmodels; the "shadow" masks aren't quite right.