Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Update to Bevy 0.10#72

Merged
aevyrie merged 6 commits intoaevyrie:mainfrom
soerenmeier:bevy-0.10
Mar 24, 2023
Merged

Update to Bevy 0.10#72
aevyrie merged 6 commits intoaevyrie:mainfrom
soerenmeier:bevy-0.10

Conversation

@soerenmeier
Copy link
Copy Markdown
Contributor

@soerenmeier soerenmeier commented Mar 7, 2023

I think everything should be working as in the previous version but I haven't used this crate myself.

@faulesocke
Copy link
Copy Markdown

You've added windows line endings. You should probably check your git configuration.

@soerenmeier
Copy link
Copy Markdown
Contributor Author

Since the last force push they should be gone. Some bug with sublime merge.

Copy link
Copy Markdown

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration appears to be done correctly :) Testing this out in Leafwing-Studios/Emergence#500

@faulesocke
Copy link
Copy Markdown

Ah interesting, I got fooled by git. All files are with Windows line-endings but git show only shows them in the lines that were added, not in removed or untouched lines.

Also played around with the module a bit and it seems to work just fine with 0.10!

Copy link
Copy Markdown

@Malax Malax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this branch for some days now and it just worked for me :)

@dimvoly
Copy link
Copy Markdown

dimvoly commented Mar 16, 2023

In lib.rs on lines 410 and 412, you'd want to cover the case where the entity is visible, but visibility is not inherited:

if let RaycastMethod::Screenspace(_) = pick_source.cast_method {
		(visibility == Visibility::Inherited && comp_visibility.is_visible())
		||
		(visibility == Visibility::Visible && comp_visibility.is_visible())
	} else {
		visibility == Visibility::Inherited
		||
		visibility == Visibility::Visible
};

As it is now, it's possible to end up with visible entities that you don't raycast to (and therefore can't pick via bevy_mod_picking in my use case).

Entities can now be visible even if their parents are not.
@soerenmeier
Copy link
Copy Markdown
Contributor Author

You're right, I wen't with the migration guide but it makes more sense, to take into account Visibility::Visible.
I took the liberty to remove manually checking Visibility since that is already done in the visibility_propagate_system of bevy and now rely on ComputedVisibility.

@luke-biel
Copy link
Copy Markdown

@aevyrie any chance this gets merged?

@aevyrie aevyrie merged commit 5226239 into aevyrie:main Mar 24, 2023
@aevyrie
Copy link
Copy Markdown
Owner

aevyrie commented Mar 24, 2023

Thanks @soerenmeier for your effort here, and everyone else for your patience. ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants