Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Migrate to bevy 0.10#191

Merged
aevyrie merged 8 commits intoaevyrie:mainfrom
Fincap:migrate-bevy-0.10.0
Mar 24, 2023
Merged

Migrate to bevy 0.10#191
aevyrie merged 8 commits intoaevyrie:mainfrom
Fincap:migrate-bevy-0.10.0

Conversation

@Fincap
Copy link
Copy Markdown
Contributor

@Fincap Fincap commented Mar 8, 2023

Hi all,

I've tried my hand at migrating this plugin to be compatible with the new Bevy 0.10 version. This is forked from the main branch and not the beta branch, with the intent of getting a working version of this plugin released ASAP.

This is currently in draft phase, as there are a couple outstanding issues. While the changes committed will compile fine, functionality when executing the examples is broken. I am creating this pull request now to seek assistance with fixing this issue before finalising.

I will leave annotations describing the issues requiring resolution. Any and all responses are appreciated :)

@Fincap
Copy link
Copy Markdown
Contributor Author

Fincap commented Mar 8, 2023

Additionally, given the issues get resolved, should a commit be made to bump the version of the plugin to something like 0.11.1 as a "bridge" version that is compatible with the latest bevy version and is available to be used while the beta refactor is still undergoing completion?

@Fincap
Copy link
Copy Markdown
Contributor Author

Fincap commented Mar 8, 2023

Thanks for your fix @soerenmeier :) Once aevyrie/bevy_mod_raycast#72 is approved, I will update the cargo file and take this PR out of draft mode.

@Fincap
Copy link
Copy Markdown
Contributor Author

Fincap commented Mar 10, 2023

I realised that removing many of the PickingSystem variants, while not impacting the library or examples, may inadvertently break module user's reliance on the labels of particular systems.

A result of this is that each plugin's systems are now individually labelled in PickingSystem, however three additional sets have been created (PickingSet, InteractableSet, and CustomHighlightSet) which represent the three "groups" of systems. They are used in the library to order each system and apply run conditions. Alternatively, these three variants can be removed and a distributive_run_if can be applied to the systems tuple, but that means that each system in the set is individually queried for its run condition each loop rather than one for the system set as a whole.

@ghost
Copy link
Copy Markdown

ghost commented Mar 20, 2023

Any news about the upgrade?

@Fincap
Copy link
Copy Markdown
Contributor Author

Fincap commented Mar 21, 2023

Any news about the upgrade?

I am still waiting for bevy_mod_raycast to be updated to 0.10 before moving this PR out of draft.

In the meantime, if you'd like to use this branch in your project you can update your Cargo.toml to include:
bevy_mod_picking = {git = "https://github.com/Fincap/bevy_mod_picking", branch = "migrate-bevy-0.10.0"}

@ghost
Copy link
Copy Markdown

ghost commented Mar 21, 2023

bevy_mod_picking = {git = "https://github.com/Fincap/bevy_mod_picking", branch = "migrate-bevy-0.10.0"}

Thank you works fine 👍

@Fincap Fincap marked this pull request as ready for review March 24, 2023 05:54
Copy link
Copy Markdown
Owner

@aevyrie aevyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you.

@aevyrie aevyrie merged commit e685eea into aevyrie:main Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants