Add JAX implementation for InvGammaRV#1480
Conversation
3dd7e49 to
8c6825e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
=======================================
Coverage 75.06% 75.06%
=======================================
Files 194 194
Lines 50091 50101 +10
Branches 12096 12097 +1
=======================================
+ Hits 37600 37610 +10
Misses 10170 10170
Partials 2321 2321
|
InvGammaRVInvGammaRV
Yes, definitely. |
Is that still an issue now that #1482 is merged? |
brandonwillard
left a comment
There was a problem hiding this comment.
I pushed some small changes and squashed; should be ready to merge after passing.
It is not an issue anymore. |
|
Thanks a lot, @PaulScemama! |
|
Thank you! @brandonwillard I learned a lot. |
This PR is a draft to close #1368. Furthermore, I had to change the
.pre-commit-config.yamlslightly to pass themypycheck. This bug has been discussed in #1474 (reply in thread).@brandonwillard @rlouf let me know what you both think regarding the
types-setuptoolsissue. If it hasn't affected anyone else then I would assume you wouldn't want the change to the.pre-commit-config.yaml.Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commitis installed and set up.EDIT:
Something that I didn't realize in the beginning...from wolfram:
"the inverse gamma distribution with shape parameter$\alpha$ and scale parameter $\beta$ is the distribution followed by the inverse of a gamma distribution with shape parameter $\alpha$ and scale parameter $\color{red} 1 / \beta$ ."
Could be useful to say something like:
"the InvGamma(shape, scale) is equivalent to taking the reciprocal of samples from a Gamma(shape, 1 / scale) distribution" in the docs.