Skip to content

[WIP] Address feedback on async creation cleanup changes #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamhathcock merged 4 commits into from
Jan 16, 2026
Merged

[WIP] Address feedback on async creation cleanup changes #1141

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b34dd6
Initial plan
Copilot Jan 16, 2026
6e5e47f
Update SevenZipFactory to consistently call OpenAsyncArchive methods
Copilot Jan 16, 2026
2180df3
Pass CancellationToken.None explicitly to OpenAsyncArchive methods
Copilot Jan 16, 2026
cfe59fc
Merge branch 'adam/async-creation' into copilot/sub-pr-1132
adamhathcock Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/SharpCompress/Factories/SevenZipFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,15 @@ public IArchive OpenArchive(Stream stream, ReaderOptions? readerOptions = null)

/// <inheritdoc/>
public IAsyncArchive OpenAsyncArchive(Stream stream, ReaderOptions? readerOptions = null) =>
SevenZipArchive.OpenAsyncArchive(stream, readerOptions);
SevenZipArchive.OpenAsyncArchive(stream, readerOptions, CancellationToken.None);

/// <inheritdoc/>
public IArchive OpenArchive(FileInfo fileInfo, ReaderOptions? readerOptions = null) =>
SevenZipArchive.OpenArchive(fileInfo, readerOptions);

/// <inheritdoc/>
public IAsyncArchive OpenAsyncArchive(FileInfo fileInfo, ReaderOptions? readerOptions = null) =>
SevenZipArchive.LoadFactoryAsync(fileInfo, readerOptions);
SevenZipArchive.OpenAsyncArchive(fileInfo, readerOptions, CancellationToken.None);

#endregion

Expand All @@ -78,7 +78,7 @@ public IArchive OpenArchive(
public IAsyncArchive OpenAsyncArchive(
IReadOnlyList<Stream> streams,
ReaderOptions? readerOptions = null
) => (IAsyncArchive)OpenArchive(streams, readerOptions);
) => SevenZipArchive.OpenAsyncArchive(streams, readerOptions, CancellationToken.None);

/// <inheritdoc/>
public IArchive OpenArchive(
Expand All @@ -91,11 +91,7 @@ public IAsyncArchive OpenAsyncArchive(
IReadOnlyList<FileInfo> fileInfos,
ReaderOptions? readerOptions = null,
CancellationToken cancellationToken = default
)
{
cancellationToken.ThrowIfCancellationRequested();
return (IAsyncArchive)OpenArchive(fileInfos, readerOptions);
}
) => SevenZipArchive.OpenAsyncArchive(fileInfos, readerOptions, cancellationToken);

#endregion

Expand Down