Skip to content

[WIP] Address feedback on async creation cleanup changes#1141

Merged
adamhathcock merged 4 commits intoadam/async-creationfrom
copilot/sub-pr-1132
Jan 16, 2026
Merged

[WIP] Address feedback on async creation cleanup changes#1141
adamhathcock merged 4 commits intoadam/async-creationfrom
copilot/sub-pr-1132

Conversation

Copy link
Contributor

Copilot AI commented Jan 16, 2026

  • Understand the current async architecture in SevenZipArchive
  • Identify the issue with OpenAsyncArchive methods in SevenZipFactory
  • Update SevenZipFactory.OpenAsyncArchive methods to call SevenZipArchive.OpenAsyncArchive instead of casting sync OpenArchive
  • Ensure cancellation tokens are passed through where available
  • Test the changes
  • Run code review and address feedback
  • Run security scan

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@adamhathcock adamhathcock marked this pull request as ready for review January 16, 2026 10:12
@adamhathcock adamhathcock merged commit 1cc80e7 into adam/async-creation Jan 16, 2026
@adamhathcock adamhathcock deleted the copilot/sub-pr-1132 branch January 16, 2026 10:12
Copilot AI requested a review from adamhathcock January 16, 2026 10:12
Copilot stopped work on behalf of adamhathcock due to an error January 16, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants