chat adaptive layout and general improvements by gtalha07 · Pull Request #881 · acterglobal/a3

gtalha07 · 2023-08-23T23:46:53Z

Chat Adaptive Layout i.e. Responsive Split Views for desktop. (Fixes Chat overviewlist when we have enough side-space #844)
General code pattern improvements.

gtalha07 · 2023-08-23T23:49:52Z

Normal Split View:

Smaller Split View:

Full Split View:

bitfriend · 2023-08-24T17:14:32Z

app/lib/features/activities/widgets/notification_card.dart

        final convo = notification.convo()!;
        avatar = Consumer(
-          builder: (ctx, ref, child) {
+          builder: (context, ref, child) {


Actually I renamed inner context to ctx so that it can be distinguished with outer context.

gnunicorn · 2023-08-25T07:33:52Z

tested. love it!

gnunicorn · 2023-08-25T07:36:05Z

Found one problem when routing to the dashboard though:

flutter:  -------      refreshing news
[2023-08-25][09:32:41][acter::platform::native][ERROR] dependOnInheritedWidgetOfExactType<UncontrolledProviderScope>() or dependOnInheritedElement() was called before _DashboardState.initState() completed.
When an inherited widget changes, for example if the value of Theme.of() changes, its dependent widgets are rebuilt. If the dependent widget's reference to the inherited widget is in a constructor or an initState() method, then the rebuilt dependent widget will not reflect the changes in the inherited widget.
Typically references to inherited widgets should occur in widget build() methods. Alternatively, initialization based on inherited widgets can be placed in the didChangeDependencies method, which is called after initState and whenever the dependencies change thereafter.
[2023-08-25][09:32:41][acter::platform::native][ERROR] #0      StatefulElement.dependOnInheritedElement.<anonymous closure> (package:flutter/src/widgets/framework.dart:5321:9)
#1      StatefulElement.dependOnInheritedElement (package:flutter/src/widgets/framework.dart:5364:6)
#2      Element.dependOnInheritedWidgetOfExactType (package:flutter/src/widgets/framework.dart:4383:14)
#3      ProviderScope.containerOf (package:flutter_riverpod/src/framework.dart:99:12)
#4      ConsumerStatefulElement._container (package:flutter_riverpod/src/consumer.dart:511:53)
#5      ConsumerStatefulElement._container (package:flutter_riverpod/src/consumer.dart)
#6      ConsumerStatefulElement.watch.<anonymous closure> (package:flutter_riverpod/src/consumer.dart:560:14)
...

gnunicorn

nice. just a glance overall, as we agreed to do the proper routing later. but still a few remarks, I'd like to have addressed before merging...

gnunicorn · 2023-08-25T07:37:58Z

app/lib/common/widgets/chat/convo_card.dart

-            Routes.chatroom.name,
-            pathParameters: {'roomId': roomId},
-          );
+          if (!isDesktop(context)) {


not fond of this, but good enough for now. let's work on the actual routing in another PR

gnunicorn · 2023-08-25T07:41:10Z

app/lib/features/chat/widgets/in_chat.dart

+                  ? const RoomPage()
+                  : const SizedBox(
+                      child: Center(
+                        child: Text('Tap on any room to see full preview'),


preview?

Suggested change

child: Text('Tap on any room to see full preview'),

child: Text('Select any room to view it'),

but maybe we also want the designers to come up with something better...

gnunicorn · 2023-08-25T07:42:18Z

app/lib/features/chat/widgets/in_chat.dart

+    final convo = ref.watch(currentConvoProvider);
+    return LayoutBuilder(
+      builder: (context, constraints) {
+        return Row(


did you ever test this on a completely fresh empty account without any chats yet? what does that look like?

No. I think it should reflect the empty placeholder for overview. But for RoomPage(), we might want to show empty or just hide it.

gnunicorn · 2023-08-25T07:44:48Z

app/lib/features/settings/widgets/in_settings.dart

-                child: SettingsMenu(),
-              ),
-              Expanded(child: child),
+              const Flexible(flex: 1, child: SettingsMenu()),


are we actually certain, this works on width == 771? Because 771/3 = 257, which is 100 smaller than the 350 it had before ...

app/lib/features/settings/widgets/settings_menu.dart

gnunicorn · 2023-08-25T07:48:08Z

app/pubspec.yaml

-  flutter_mentions: ^2.0.1
+  flutter_mentions:
+    git:
+      url: https://github.com/gtalha07/flutter_mentions.git


what is happening here?

Currently, flutter_mentions highly requested feature was to include suggestionListWidth so we can change the width of suggestion list container. I did that in my forked version as its needed for making it adaptive across different screen sizes. I am looking to open contribution PR for it but also seeing the repository being not actively maintained .i.e. last was 2 yrs ago...

Seems like the PR is already opened for review and merge, but no updates on it yet...

thanks for explanation. If we need to maintain a fork, we probably want to move it into our org though ...

gtalha07 · 2023-08-25T13:13:33Z

Found one problem when routing to the dashboard though:

flutter:  -------      refreshing news
[2023-08-25][09:32:41][acter::platform::native][ERROR] dependOnInheritedWidgetOfExactType<UncontrolledProviderScope>() or dependOnInheritedElement() was called before _DashboardState.initState() completed.
When an inherited widget changes, for example if the value of Theme.of() changes, its dependent widgets are rebuilt. If the dependent widget's reference to the inherited widget is in a constructor or an initState() method, then the rebuilt dependent widget will not reflect the changes in the inherited widget.
Typically references to inherited widgets should occur in widget build() methods. Alternatively, initialization based on inherited widgets can be placed in the didChangeDependencies method, which is called after initState and whenever the dependencies change thereafter.
[2023-08-25][09:32:41][acter::platform::native][ERROR] #0      StatefulElement.dependOnInheritedElement.<anonymous closure> (package:flutter/src/widgets/framework.dart:5321:9)
#1      StatefulElement.dependOnInheritedElement (package:flutter/src/widgets/framework.dart:5364:6)
#2      Element.dependOnInheritedWidgetOfExactType (package:flutter/src/widgets/framework.dart:4383:14)
#3      ProviderScope.containerOf (package:flutter_riverpod/src/framework.dart:99:12)
#4      ConsumerStatefulElement._container (package:flutter_riverpod/src/consumer.dart:511:53)
#5      ConsumerStatefulElement._container (package:flutter_riverpod/src/consumer.dart)
#6      ConsumerStatefulElement.watch.<anonymous closure> (package:flutter_riverpod/src/consumer.dart:560:14)
...

I can't seem to reproduce this on my side. Been navigating in between on debug but no errors. Could you provide more detail about the issue .i.e. platform, user account etc. (Not sure if this issue is related with PR either)

gnunicorn · 2023-08-27T10:34:23Z

@gtalha07 well, then ignore this issue for now. if it comes back up, we'll deal with it then.

code cleanup and chat adaptive layout

30e1c51

gtalha07 and others added 2 commits August 24, 2023 21:48

fix overflow issues

b8e7dc6

Merge branch 'main' into issue844_chat_adaptive-layout

bc33105

gtalha07 requested review from bitfriend and gnunicorn August 24, 2023 16:53

fix lint errors

4265826

gtalha07 marked this pull request as ready for review August 24, 2023 16:59

bitfriend reviewed Aug 24, 2023

View reviewed changes

gnunicorn approved these changes Aug 25, 2023

View reviewed changes

gtalha07 added 2 commits August 25, 2023 18:05

handle space chats routing and feedback changes

ca85a78

add changes doc

40d81e7

gtalha07 merged commit 6a79f3d into acterglobal:main Aug 27, 2023

	child: Text('Tap on any room to see full preview'),
	child: Text('Select any room to view it'),

Uh oh!

Conversation

gtalha07 commented Aug 23, 2023 • edited by gnunicorn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gtalha07 commented Aug 23, 2023

Normal Split View:

Smaller Split View:

Full Split View:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnunicorn commented Aug 25, 2023

Uh oh!

gnunicorn commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gnunicorn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gtalha07 Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gtalha07 commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gnunicorn commented Aug 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gtalha07 commented Aug 23, 2023 •

edited by gnunicorn

Loading

gnunicorn commented Aug 25, 2023 •

edited

Loading

gtalha07 Aug 25, 2023 •

edited

Loading

gtalha07 commented Aug 25, 2023 •

edited

Loading