Skip to content

SMQ-2260 - Log full errors in logging middleware #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

SMQ-2260 - Log full errors in logging middleware #3003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions auth/api/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 39 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L39 

Added line #L39 was not covered by tests
lm.logger.Warn("Issue key failed", args...)
return
}
Expand All @@ -53,7 +53,7 @@
slog.String("key_id", id),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 56 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L56 

Added line #L56 was not covered by tests
lm.logger.Warn("Revoke key failed", args...)
return
}
Expand All @@ -70,7 +70,7 @@
slog.String("key_id", id),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 73 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L73 

Added line #L73 was not covered by tests
lm.logger.Warn("Retrieve key failed", args...)
return
}
Expand All @@ -90,7 +90,7 @@
),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 93 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L93 

Added line #L93 was not covered by tests
lm.logger.Warn("Identify key failed", args...)
return
}
Expand All @@ -116,7 +116,7 @@
slog.String("permission", pr.Permission),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 119 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L119 

Added line #L119 was not covered by tests
lm.logger.Warn("Authorize failed", args...)
return
}
Expand All @@ -134,7 +134,7 @@
slog.String("pat_duration", duration.String()),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 137 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L137 

Added line #L137 was not covered by tests
lm.logger.Warn("Create PAT failed", args...)
return
}
Expand All @@ -151,7 +151,7 @@
slog.String("name", name),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 154 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L154 

Added line #L154 was not covered by tests
lm.logger.Warn("Update PAT name failed", args...)
return
}
Expand All @@ -168,7 +168,7 @@
slog.String("description", description),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 171 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L171 

Added line #L171 was not covered by tests
lm.logger.Warn("Update PAT description failed", args...)
return
}
Expand All @@ -184,7 +184,7 @@
slog.String("pat_id", patID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 187 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L187 

Added line #L187 was not covered by tests
lm.logger.Warn("Retrieve PAT failed", args...)
return
}
Expand All @@ -201,7 +201,7 @@
slog.Uint64("offset", pm.Offset),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 204 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L204 

Added line #L204 was not covered by tests
lm.logger.Warn("List PATS failed", args...)
return
}
Expand All @@ -219,7 +219,7 @@
slog.String("pat_id", pm.PatID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 222 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L222 

Added line #L222 was not covered by tests
lm.logger.Warn("List Scopes failed", args...)
return
}
Expand All @@ -235,7 +235,7 @@
slog.String("pat_id", patID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 238 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L238 

Added line #L238 was not covered by tests
lm.logger.Warn("Delete PAT failed", args...)
return
}
Expand All @@ -252,7 +252,7 @@
slog.String("pat_duration", duration.String()),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 255 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L255 

Added line #L255 was not covered by tests
lm.logger.Warn("Reset PAT secret failed", args...)
return
}
Expand All @@ -268,7 +268,7 @@
slog.String("pat_id", patID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 271 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L271 

Added line #L271 was not covered by tests
lm.logger.Warn("Revoke PAT secret failed", args...)
return
}
Expand All @@ -283,7 +283,7 @@
slog.String("duration", time.Since(begin).String()),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 286 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L286 

Added line #L286 was not covered by tests
lm.logger.Warn("Remove all PAT failed", args...)
return
}
Expand All @@ -308,7 +308,7 @@
slog.Group("scope", groupArgs...),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 311 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L311 

Added line #L311 was not covered by tests
lm.logger.Warn("Add PAT scope failed", args...)
return
}
Expand All @@ -329,7 +329,7 @@
slog.Group("scope", groupArgs...),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 332 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L332 

Added line #L332 was not covered by tests
lm.logger.Warn("Remove entry from PAT scope failed", args...)
return
}
Expand All @@ -345,7 +345,7 @@
slog.String("pat_id", patID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 348 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L348 

Added line #L348 was not covered by tests
lm.logger.Warn("Remove all scopes from PAT failed", args...)
return
}
Expand All @@ -360,7 +360,7 @@
slog.String("duration", time.Since(begin).String()),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 363 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L363 

Added line #L363 was not covered by tests
lm.logger.Warn("Identify PAT failed", args...)
return
}
Expand All @@ -379,7 +379,7 @@
slog.String("entities", entityID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 382 in auth/api/logging.go

View check run for this annotation

Codecov / codecov/patch

auth/api/logging.go#L382 

Added line #L382 was not covered by tests
lm.logger.Warn("Authorize PAT failed complete successfully", args...)
return
}
Expand Down
10 changes: 5 additions & 5 deletions certs/api/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
slog.String("ttl", ttl),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 40 in certs/api/logging.go

View check run for this annotation

Codecov / codecov/patch

certs/api/logging.go#L40 

Added line #L40 was not covered by tests
lm.logger.Warn("Issue certificate failed", args...)
return
}
Expand All @@ -61,7 +61,7 @@
),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 64 in certs/api/logging.go

View check run for this annotation

Codecov / codecov/patch

certs/api/logging.go#L64 

Added line #L64 was not covered by tests
lm.logger.Warn("List certificates failed", args...)
return
}
Expand All @@ -87,7 +87,7 @@
),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 90 in certs/api/logging.go

View check run for this annotation

Codecov / codecov/patch

certs/api/logging.go#L90 

Added line #L90 was not covered by tests
lm.logger.Warn("List certifcates serials failed", args...)
return
}
Expand All @@ -107,7 +107,7 @@
slog.String("serial_id", serialID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 110 in certs/api/logging.go

View check run for this annotation

Codecov / codecov/patch

certs/api/logging.go#L110 

Added line #L110 was not covered by tests
lm.logger.Warn("View certificate failed", args...)
return
}
Expand All @@ -127,7 +127,7 @@
slog.String("client_id", clientID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 130 in certs/api/logging.go

View check run for this annotation

Codecov / codecov/patch

certs/api/logging.go#L130 

Added line #L130 was not covered by tests
lm.logger.Warn("Revoke certificate failed", args...)
return
}
Expand Down
8 changes: 4 additions & 4 deletions coap/api/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
args = append(args, slog.String("subtopic", msg.GetSubtopic()))
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 42 in coap/api/logging.go

View check run for this annotation

Codecov / codecov/patch

coap/api/logging.go#L42 

Added line #L42 was not covered by tests
lm.logger.Warn("Publish message failed", args...)
return
}
Expand All @@ -62,7 +62,7 @@
args = append(args, slog.String("subtopic", subtopic))
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 65 in coap/api/logging.go

View check run for this annotation

Codecov / codecov/patch

coap/api/logging.go#L65 

Added line #L65 was not covered by tests
lm.logger.Warn("Subscribe failed", args...)
return
}
Expand All @@ -85,7 +85,7 @@
args = append(args, slog.String("subtopic", subtopic))
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 88 in coap/api/logging.go

View check run for this annotation

Codecov / codecov/patch

coap/api/logging.go#L88 

Added line #L88 was not covered by tests
lm.logger.Warn("Unsubscribe failed", args...)
return
}
Expand All @@ -109,7 +109,7 @@
args = append(args, slog.String("subtopic", subtopic))
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 112 in coap/api/logging.go

View check run for this annotation

Codecov / codecov/patch

coap/api/logging.go#L112 

Added line #L112 was not covered by tests
lm.logger.Warn("Unsubscribe failed", args...)
return
}
Expand Down
14 changes: 7 additions & 7 deletions domains/middleware/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
slog.String("domain_id", invitation.DomainID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 186 in domains/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

domains/middleware/logging.go#L186 

Added line #L186 was not covered by tests
lm.logger.Warn("Send invitation failed", args...)
return
}
Expand All @@ -200,7 +200,7 @@
slog.String("domain_id", domainID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 203 in domains/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

domains/middleware/logging.go#L203 

Added line #L203 was not covered by tests
lm.logger.Warn("View invitation failed", args...)
return
}
Expand All @@ -220,7 +220,7 @@
),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 223 in domains/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

domains/middleware/logging.go#L223 

Added line #L223 was not covered by tests
lm.logger.Warn("List invitations failed", args...)
return
}
Expand All @@ -240,7 +240,7 @@
),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 243 in domains/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

domains/middleware/logging.go#L243 

Added line #L243 was not covered by tests
lm.logger.Warn("List domain invitations failed", args...)
return
}
Expand All @@ -256,7 +256,7 @@
slog.String("domain_id", domainID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 259 in domains/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

domains/middleware/logging.go#L259 

Added line #L259 was not covered by tests
lm.logger.Warn("Accept invitation failed", args...)
return
}
Expand All @@ -272,7 +272,7 @@
slog.String("domain_id", domainID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 275 in domains/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

domains/middleware/logging.go#L275 

Added line #L275 was not covered by tests
lm.logger.Warn("Reject invitation failed", args...)
return
}
Expand All @@ -289,7 +289,7 @@
slog.String("domain_id", domainID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 292 in domains/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

domains/middleware/logging.go#L292 

Added line #L292 was not covered by tests
lm.logger.Warn("Delete invitation failed", args...)
return
}
Expand Down
6 changes: 3 additions & 3 deletions journal/middleware/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 42 in journal/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

journal/middleware/logging.go#L42 

Added line #L42 was not covered by tests
lm.logger.Warn("Save journal failed", args...)
return
}
Expand All @@ -63,7 +63,7 @@
),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 66 in journal/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

journal/middleware/logging.go#L66 

Added line #L66 was not covered by tests
lm.logger.Warn("Retrieve all journals failed", args...)
return
}
Expand All @@ -82,7 +82,7 @@
slog.String("domain_id", session.DomainID),
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 85 in journal/middleware/logging.go

View check run for this annotation

Codecov / codecov/patch

journal/middleware/logging.go#L85 

Added line #L85 was not covered by tests
lm.logger.Warn("Retrieve client telemetry failed", args...)
return
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/messaging/handler/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
args = append(args, slog.Any("topics", *topics))
}
if err != nil {
args = append(args, slog.Any("error", err))
args = append(args, slog.String("error", err.Error()))

Check warning on line 85 in pkg/messaging/handler/logging.go

View check run for this annotation

Codecov / codecov/patch

pkg/messaging/handler/logging.go#L85 

Added line #L85 was not covered by tests
lm.logger.Warn(action+" failed", args...)
return
}
Expand Down
Loading
Loading