Skip to content

Conversation

@felixgateru
Copy link
Contributor

What type of PR is this?

This is a refactor as it changes logging of errors.

What does this do?

This pr:

  • changes all existing logging instances from using args = append(args, slog.Any("error", err)) to
    args = append(args, slog.String("error", err.Error()))

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

No

Did you document any new/modified feature?

No

Notes

@felixgateru felixgateru requested a review from a team as a code owner July 9, 2025 09:32
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 23.73%. Comparing base (fa5b6b8) to head (76868a3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
users/middleware/logging.go 0.00% 23 Missing ⚠️
auth/api/logging.go 0.00% 20 Missing ⚠️
domains/middleware/logging.go 0.00% 7 Missing ⚠️
certs/api/logging.go 0.00% 5 Missing ⚠️
coap/api/logging.go 0.00% 4 Missing ⚠️
journal/middleware/logging.go 0.00% 3 Missing ⚠️
ws/api/logging.go 0.00% 2 Missing ⚠️
pkg/messaging/handler/logging.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3003      +/-   ##
==========================================
+ Coverage   23.70%   23.73%   +0.03%     
==========================================
  Files         360      277      -83     
  Lines       67769    59057    -8712     
==========================================
- Hits        16063    14019    -2044     
+ Misses      50922    44346    -6576     
+ Partials      784      692      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dborovcanin dborovcanin merged commit 1c0400d into absmach:main Jul 9, 2025
7 of 9 checks passed
nyagamunene pushed a commit to nyagamunene/supermq that referenced this pull request Jul 9, 2025
arvindh123 pushed a commit that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Log doesn't have full errors, instead it returns limited error information

2 participants