Make endpoint special-case localhost and IP addresses
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmars
reviewed
Apr 17, 2025
I believe it's quite common (e.g. for Realtime devs) to want to point to a local Realtime. Or, for example in the SDK team, to want to point to a local reverse proxy for interception. Turns out that it's already special-cased in ably-go [1], so let's add to spec. Since ably-go is the only place that the `endpoint` functionality has been implemented so far, I'm just changing the existing spec point and will update ably-go to reflect. [1] https://github.com/ably/ably-go/blob/17f6575773b28a146ac04bfaf3b8de44ce1ff162/ably/options.go#L506-L510
lawrence-forooghian
force-pushed
the
allow-localhost-and-ip-addresses-using-endpoint-option
branch
from
8db03d7 to
f28cad3
Compare
lawrence-forooghian
added a commit
to ably/ably-go
that referenced
this pull request
Apr 22, 2025
Reflects the changes of spec commit f28cad3 from [1], which were themselves based on the special-case logic implemented in this repo. [1] ably/specification#302
lawrence-forooghian
added a commit
to ably/ably-go
that referenced
this pull request
Apr 22, 2025
Reflects the changes of spec commit f28cad3 from [1], which were themselves based on the special-case logic implemented in this repo. [1] ably/specification#302
lmars
approved these changes
Apr 22, 2025
lawrence-forooghian
merged commit b2c94db
into
clarify-nonprod-routing-policy
2 checks passed
lawrence-forooghian
deleted the
allow-localhost-and-ip-addresses-using-endpoint-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it's quite common (e.g. for Realtime devs) to want to point to a local Realtime. Or, for example in the SDK team, to want to point to a local reverse proxy for interception.
Turns out that it's already special-cased in ably-go, so let's add to spec.