Readability tweaks for new domain logic #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Oops, forgot that (now-merged) #302 was stacked on top of this PR, so its contents are now here. |
lmars
reviewed
Apr 23, 2025
For conditional things, consistently say "if it's x, determined by y", and don't use conditional language for non-conditional REC1b4.
The existing language implies that the primary domain equals the routing policy name, which is not what the referenced spec points say.
For consistency with REC2c4.
It was being used in two different ways in REC1b3. Per Laura ([1] and [2]) there is no such thing as a "routing policy name", and the term for the subcomponent is the "routing policy ID". [1] https://ably-real-time.slack.com/archives/CURL4U2FP/p1744878569805559 [2] #301 (comment)
I believe it's quite common (e.g. for Realtime devs) to want to point to a local Realtime. Or, for example in the SDK team, to want to point to a local reverse proxy for interception. Turns out that it's already special-cased in ably-go [1], so let's add to spec. Since ably-go is the only place that the `endpoint` functionality has been implemented so far, I'm just changing the existing spec point and will update ably-go to reflect. [1] https://github.com/ably/ably-go/blob/17f6575773b28a146ac04bfaf3b8de44ce1ff162/ably/options.go#L506-L510
lawrence-forooghian
force-pushed
the
clarify-nonprod-routing-policy
branch
from
b2c94db to
cbe7c83
Compare
lmars
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to the language in #213, for readability.