[WEB-4683] Overhaul of UI for app header, navigation, ToC, page header and footer#2959
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
675065c to
c4d7f24
Compare
c4d7f24 to
3a77f8a
Compare
3a77f8a to
9786a76
Compare
6015277 to
5c1e160
Compare
382e677 to
1935e45
Compare
…lift z-index of top-level accordion items
64f2ee2 to
3e38806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is culmination of a series of already-reviewed PRs upgrading the UI/UX of various key structural aspects of the docs site, namely the:
This represents a huge change for the look and feel of the docs site, moving us to a superior navigational experience that's more inkeeping with the quality of our competitors. That's corpospeak for Jamie W and Mark done good.
That said, this work also allows us to streamline things technically. I've taken the opportunity to lean more heavily on Radix UI for the foundational of these components, while also decoupling from Ably UI where possible and also improving the capabilities of the IA that powers the nav.
Give it a test run here: https://ably-docs-web-4684-docs-cdifa4.herokuapp.com/