Fix ably-python version regexp in test_request_headers test

[VeskeR]

It didn't account that ably-python versions can have multiple digits for major/minor/patch parts

Summary by CodeRabbit

• Tests
  • Refined the version number validation, improving flexibility to support multi-digit version segments in header checks.

[coderabbitai]

Walkthrough

This pull request updates the regular expression used to validate the format of the Ably-Agent header in the test_request_headers method of the TestRestHttp class. The regex change now permits one or more digits for the major, minor, and patch version segments, as well as for the beta version component. No alterations have been made to exported or public entities.

Changes

File	Change Summary
test/ably/.../resthttp_test.py	Modified the regex pattern in the test_request_headers method to allow multiple digits in the version segments and beta version indicator.

Suggested reviewers

• sacOO7
• ttypic

Poem

I'm a coding rabbit, leaping through the night,
Tweaking regex patterns with all my might.
Versions now shine with more digits in view,
A burst of precision in every test we pursue.
Hoppin' in joy, our changes are bright!
🥕🐇

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

test/ably/rest/resthttp_test.py (1)

195-195: Good update to the regex pattern for version validation.

The change from \d to \d+ properly allows for multi-digit version components in the ably-python version string, which aligns with semantic versioning standards. This fixes the issue where version numbers like "1.10.0" or "2.3.11" would fail validation with the previous pattern.

For consistency, consider also updating the Python version pattern from python\/\d.\d+.\d+ to python\/\d+.\d+.\d+ to handle the case when Python reaches version 10 or higher.

-        expr = r"^ably-python\/\d+.\d+.\d+(-beta\.\d+)? python\/\d.\d+.\d+$"
+        expr = r"^ably-python\/\d+.\d+.\d+(-beta\.\d+)? python\/\d+.\d+.\d+$"

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7bd2ca and 5ffd21a.

📒 Files selected for processing (1)

• test/ably/rest/resthttp_test.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: check (3.13)
• GitHub Check: check (3.12)
• GitHub Check: check (3.11)
• GitHub Check: check (3.10)
• GitHub Check: check (3.9)
• GitHub Check: check (3.8)

[sacOO7]

LGTM ( as long as CI is green and all tests passes )