[ECO-5236] Update `websockets` dependency #592

VeskeR · 2025-03-04T08:15:51Z

Resolves #591

Summary by CodeRabbit

Chores
- Refined dependency management to enhance compatibility across different Python versions.

`websockets` dropped support for python 3.7 starting from version 12 [1]. [1] https://websockets.readthedocs.io/en/stable/project/changelog.html#id31

Resolves #591

coderabbitai · 2025-03-04T08:15:59Z

Walkthrough

The pull request updates the pyproject.toml file to refine the dependency configuration for the websockets package. The dependency declaration is now split into two conditional sections based on the Python version: one for Python 3.7 (allowing versions ≥10.0 and <12.0) and another for Python 3.8 (allowing versions ≥12.0 and <14.0).

Changes

File	Change Summary
pyproject.toml	Split `websockets` dependency declaration into two entries: one for Python 3.7 (>=10.0, <12.0) and one for Python 3.8 (>=12.0, <14.0).

Poem

I’m a rabbit with lines of code to share,
Hopping through changes with a happy stare.
Dependencies split, precise and neat,
Like carrots in rows, a tasty treat.
Bounding forward with a joyful beat!
🥕🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7bd2ca and 850b2bb.

⛔ Files ignored due to path filters (1)

poetry.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

pyproject.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: check (3.10)

🔇 Additional comments (1)

pyproject.toml (1)

40-43: Refined Websockets Dependency Specification

The updated websockets dependency now conditionally specifies version ranges based on the Python version, which offers better granularity. For Python 3.7 (using python = "~3.7"), the allowed versions are between 10.0 (inclusive) and 12.0 (exclusive). For Python 3.8 (using python = "^3.8"), the allowed versions are between 12.0 (inclusive) and 14.0 (exclusive). This approach aligns well with similar dependency patterns in the file (e.g., for httpx), ensuring that consumers in different Python environments receive the appropriate dependency version.

Please verify that these version bounds meet your compatibility and testing requirements across all intended Python versions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

VeskeR · 2025-03-04T08:54:36Z

test_request_headers tests errors are fixed in #593

sacOO7 · 2025-03-04T09:17:27Z

Not sure why CI is red : (

sacOO7 · 2025-03-04T14:09:53Z

@coderabbitai review

coderabbitai · 2025-03-04T14:10:01Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

VeskeR · 2025-03-04T14:10:35Z

test_capability_change_without_loss_of_continuity test flakiness is suspected to be becaucse of frontdoor used on sandbox

sacOO7 · 2025-03-04T14:12:12Z

test_capability_change_without_loss_of_continuity test flakiness is suspected to be becaucse of frontdoor used on sandbox

Agreed. Worked on ably-python in the past. We never faced tests flakiness till now. This is surely due to introduction of frontdoor.

pyproject.toml

sacOO7

LGTM

VeskeR added 2 commits March 4, 2025 08:11

Fix websockets dependency for python 3.7

647ba03

`websockets` dropped support for python 3.7 starting from version 12 [1]. [1] https://websockets.readthedocs.io/en/stable/project/changelog.html#id31

Update websockets dependency to support version 13

850b2bb

Resolves #591

VeskeR requested review from sacOO7 and ttypic March 4, 2025 08:15

github-actions bot deployed to staging/pull/592/features March 4, 2025 08:16 View deployment

VeskeR mentioned this pull request Mar 4, 2025

Conflict with google genai #591

Closed

sacOO7 reviewed Mar 4, 2025

View reviewed changes

pyproject.toml Show resolved Hide resolved

sacOO7 approved these changes Mar 4, 2025

View reviewed changes

VeskeR merged commit b439046 into main Mar 4, 2025
3 of 10 checks passed

VeskeR deleted the 591/update-websockets-dependency branch March 4, 2025 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ECO-5236] Update `websockets` dependency #592

[ECO-5236] Update `websockets` dependency #592

Uh oh!

VeskeR commented Mar 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 4, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

VeskeR commented Mar 4, 2025

Uh oh!

sacOO7 commented Mar 4, 2025

Uh oh!

sacOO7 commented Mar 4, 2025

Uh oh!

coderabbitai bot commented Mar 4, 2025

Uh oh!

VeskeR commented Mar 4, 2025

Uh oh!

sacOO7 commented Mar 4, 2025

Uh oh!

Uh oh!

sacOO7 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

[ECO-5236] Update websockets dependency #592

[ECO-5236] Update websockets dependency #592

Uh oh!

Conversation

VeskeR commented Mar 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

VeskeR commented Mar 4, 2025

Uh oh!

sacOO7 commented Mar 4, 2025

Uh oh!

sacOO7 commented Mar 4, 2025

Uh oh!

coderabbitai bot commented Mar 4, 2025

Uh oh!

VeskeR commented Mar 4, 2025

Uh oh!

sacOO7 commented Mar 4, 2025

Uh oh!

Uh oh!

sacOO7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

[ECO-5236] Update `websockets` dependency #592

[ECO-5236] Update `websockets` dependency #592

VeskeR commented Mar 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)