-
Notifications
You must be signed in to change notification settings - Fork 413
feat(Application): Support application emojis #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
83983b8
Added support for application emojis
areomr 41c5213
Merge branch 'dev' into app-emojis
areomr ce5b643
Better typings for application emojis (make ApplicationEmojiOptions e…
areomr f6a9f43
fix return in getEmojis
0fcb3b9
Reverted previous change on getEmojis +some typings
areomr 7239a62
Fixed a type
areomr 0f0bcf5
Merge branch 'dev' into app-emojis
areomr 20cda1f
Some typings
areomr bb968b8
Merge branch 'dev' into app-emojis
areomr 4b30a1a
Updated user cache
areomr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2640,10 +2640,10 @@ class Client extends EventEmitter { | |
|
|
||
| /** | ||
| * Get the emojis for this application | ||
| * @returns {Promise<Array<Object>>} Resolves with an array of emoji objects | ||
| * @returns {Promise<Object>} Resolves with an object that contains a property "items" which is an array of emoji objects | ||
| */ | ||
| getEmojis() { | ||
| return this.requestHandler.request("GET", Endpoints.APPLICATION_EMOJIS(this.application.id), true).then((data) => data.items); | ||
| return this.requestHandler.request("GET", Endpoints.APPLICATION_EMOJIS(this.application.id), true); | ||
|
||
| } | ||
|
|
||
| /** | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This returns an array of emojis, not something we send to discord