feat(Application): Support application emojis #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsian03
requested changes
Oct 12, 2024
lib/Client.js
Outdated
| * @returns {Promise<Object>} Resolves with an emoji object | ||
| */ | ||
| getEmoji(emojiID) { | ||
| return this.requestHandler.request("GET", Endpoints.APPLICATION_EMOJI(this.application.id, emojiID), true); |
lib/Client.js
Outdated
| * @returns {Promise<Array<Object>>} Resolves with an array of emoji objects | ||
| */ | ||
| getEmojis() { | ||
| return this.requestHandler.request("GET", Endpoints.APPLICATION_EMOJIS(this.application.id), true); |
Collaborator
There was a problem hiding this comment.
Update user cache. Also this doesn't directly return an emojis array, it returns an object containing items, which is the array of emojis
index.d.ts
Outdated
| getDiscoveryCategories(): Promise<DiscoveryCategory[]>; | ||
| getDMChannel(userID: string): Promise<DMChannel>; | ||
| getEmoji(emojiID: string): Promise<Emoji>; | ||
| getEmojis(): Promise<Emoji[]>; |
bsian03
reviewed
Oct 22, 2024
index.d.ts
Outdated
| image: string; | ||
| } | ||
| interface ApplicationEmojis { | ||
| items: ApplicationEmojiOptions[]; |
Collaborator
There was a problem hiding this comment.
This returns an array of emojis, not something we send to discord
bsian03
approved these changes
Dec 13, 2024
areodot
changed the title
flav-code
added a commit
to flavibot/eris
that referenced
this pull request
Mar 20, 2025
feat(Application): Support application emojis (abalabahaha#1559)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application-Level Emojis
DIscord has added application-level emojis.
New
Reference
TODO