Make sure CI tests do not use previous run's JIT cache#2620
Closed
Make sure CI tests do not use previous run's JIT cache#2620
Conversation
andrej
requested review from
AndraBisca,
denolf,
fifield,
jackl-xilinx,
jgmelber,
pvasireddy-amd and
stephenneuendorffer
as code owners
andrej
changed the title
fifield
approved these changes
Sep 30, 2025
Collaborator
fifield
left a comment
fifield
left a comment
There was a problem hiding this comment.
I'm tempted to rm -rf ~/.iron/* && chmod a-w ~/.iron on the runners after this lands.
mawad-amd
approved these changes
Oct 1, 2025
Collaborator
mawad-amd
left a comment
mawad-amd
left a comment
There was a problem hiding this comment.
This looks good. Thanks Andre.
Collaborator
|
Merging to test the rest of the fix in #2622 |
Collaborator
Author
|
This fix was already merged as part of #2532 (see the diff, it's empty). |
auto-merge was automatically disabled
October 2, 2025 18:40
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IRON_CACHE_HOMEenvironment variable is unique for each CI run and is supposed to ensure that the JIT-compiled binaries don't get reused/cached between CI runs. However,lit, does not by default copy all environment variables from where it's called, meaning theIRON_CACHE_HOMEenvironment variable gets dropped and cached files get generated in the~/.iron/cachedirectory instead. This should fix that, making sure the JIT targets get regenerated/tested on each CI run.This is likely what caused the latest test failures in #2532.
cc @mawad-amd