some tweaks in both the splithttp and httpupgrade packages#3579
Closed
some tweaks in both the splithttp and httpupgrade packages#3579
Conversation
Contributor
|
I think this entire PR, but certainly the description is AI-generated. One can argue that some of these changes are useful (typo fixes, indeed there is something wrong with uds, see #3577), but the PR description even references some changes that are definitely not present in the PR. Most changes here are missing justification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made some tweaks in both the splithttp and httpupgrade packages. Here's what's up:
In /splithttp/hub.go:
time.AfterFunc. Way cleaner.httpResponseBodyWriter.Write.No more deadlocks!ListenSHactually tell us when something's wrong.ListenSH. No more resource leaks.dummy server for UDS. Keeps things stable.ErrServerClosed. Smooth shutdowns, you know?And in /httpupgrade/hub.go:
innnerListeneris now innerListener. Two n's, not three!