Conversation
mmmray
reviewed
Jul 22, 2024
Contributor
mmmray
left a comment
mmmray
left a comment
There was a problem hiding this comment.
in main branch, it seems l.server may be nil or unset if uds is used
will add a test later
mmmray
reviewed
Jul 22, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| req.ContentLength = contentLength |
Contributor
There was a problem hiding this comment.
fixing a random crash I found while writing the test. It only occurs if you set a host that is syntactically invalid, in an xray client that uses domain sockets in outbound.
Contributor
|
thank you! |
leninalive
pushed a commit
to amnezia-vpn/amnezia-xray-core
that referenced
this pull request
Oct 29, 2024
Co-authored-by: mmmray <142015632+mmmray@users.noreply.github.com>
it2konst
pushed a commit
to it2konst/gametunnel-core
that referenced
this pull request
Mar 1, 2026
Co-authored-by: mmmray <142015632+mmmray@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug is introduced in v1.18.20, the unix domain socket works well before.
I don't know too much about golang and fix it with reference to the previous code.