gRPC Custom Path#1815
Merged
Conversation
Added unit tests for new methods
Member
|
感谢 PR,麻烦把 |
Member
|
再次感谢! |
yuhan6665
pushed a commit
that referenced
this pull request
Mar 28, 2023
yuhan6665
pushed a commit
to yuhan6665/Xray-core
that referenced
this pull request
Mar 31, 2023
3 tasks
it2konst
pushed a commit
to it2konst/gametunnel-core
that referenced
this pull request
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I added the ability to define custom full paths for gRPC as discussed in #1793. I added some tests as well just for the sake of it.
Here are two example configs:
Server:
{ "log": { "loglevel": "debug" }, "inbounds": [{ "listen": "127.0.0.1", "port": 12345, "protocol": "trojan", "settings": { "clients": [{ "password": "123456" } ] }, "streamSettings": { "network": "gun", "security": "none", "grpcSettings": { "serviceName": "/my/sample/path/customTun|customTunMulti" } } } ], "outbounds": [{ "protocol": "freedom" } ] }Client Tun:
{ "log": { "loglevel": "debug" }, "inbounds": [{ "listen": "127.0.0.1", "port": "10818", "protocol": "socks" } ], "outbounds": [{ "protocol": "trojan", "settings": { "servers": [{ "address": "127.0.0.1", "port": 12345, "password": "123456" } ] }, "streamSettings": { "network": "gun", "security": "none", "grpcSettings": { "serviceName": "/my/sample/path/customTun", "multiMode": false } } } ] }Client Multi Tun:
{ "log": { "loglevel": "debug" }, "inbounds": [{ "listen": "127.0.0.1", "port": "10818", "protocol": "socks" } ], "outbounds": [{ "protocol": "trojan", "settings": { "servers": [{ "address": "127.0.0.1", "port": 12345, "password": "123456" } ] }, "streamSettings": { "network": "gun", "security": "none", "grpcSettings": { "serviceName": "/my/sample/path/customTunMulti", "multiMode": true } } } ] }As you can see, we have the limitation that both
TunandTun Multiendpoints must have the same sub-route. There is a very small problem with this implementation: Service names like/will crash the app. We need to make sure that if the service name starts with/, it has at least two/in it. We should probably somehow validate the config file.This PR will close #1793