-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Closed
Description
We had a talk with @RPRX in #1790 about allowing custom paths in gRPC transport.
There is a recap of our idea.
- We can assign custom stream names for
TunandTunMulti. These strings are currently hardcoded here. Changing them shouldn't be a big deal. - Allow user to use absolute paths for gRPC. This can be determined from the prefix of
/inserviceName. But this will bring us a problem. How we are going to distinguish traffic withmultiModeset and not set?
I think implementing 1 is pretty simple and straight-forward. For 2, we can do this:
- Check if
serviceNamehas/suffix. If it does not have one, just act like before. - If it does have, we don't path escape the
serviceName. Instead, we will use absolute path defined in theserviceName+ the customTunandTunMultistream name. For example if theserviceNameis set to/my/pathand our customTunstream name iscustomTun, we will send our request towww.hostname.com/my/path/customTun. On the client side, this looks easy to implement. The implementation should take place in this file again. However, on the server side we should make sure that the gRPC library does support paths as its service name.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels