Added French strings for newsletter copy.#22596
Conversation
WalkthroughThis pull request updates the French translation strings in the newsletter JSON file. The changes include adding translations for previously empty keys, updating existing phrases with more appropriate French text, and adjusting gender-sensitive language to a more inclusive form. Specific modifications address membership prompts, content filtering options, and subscription status messages. The updates ensure that the French version of the newsletter content is clear, accurate, and inclusive. Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ghost/i18n/locales/fr/newsletter copy.json (2)
10-13: Verify the Tone for “Less like this” and “More like this” TranslationsThe translations for "Less like this" (
"Je n'ai pas aimé") and "More like this" ("J'ai adoré") use very personal feedback expressions. Typically, these phrases might be intended as UI call-to-action buttons (e.g., to filter or recommend similar content) rather than statements of personal opinion. It would be worthwhile to confirm with the localization team whether a more neutral directive—such as "Voir moins de ce type" and "Voir plus de ce type" or similar—might be more appropriate.
20-20: Refine the Upgrade Call-to-Action WordingThe translation for "Upgrade to continue reading." is rendered as "Modifiez votre abonnement pour lire la suite." While this is acceptable, the phrase "Modifiez votre abonnement" might be less immediately clear than alternatives like "Mettez à niveau votre abonnement pour continuer à lire." Consider revisiting this phrasing to ensure it conveys a clear and direct instruction for users.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ghost/i18n/locales/fr/newsletter copy.json(1 hunks)
🔇 Additional comments (1)
ghost/i18n/locales/fr/newsletter copy.json (1)
1-29: Overall JSON Structure and Placeholder IntegrityThe JSON file is well-formed and syntactically correct. All dynamic placeholders (such as
{date},{site}, and{authors}) are preserved in both the keys and values, ensuring consistency across localizations.
|
Hey @gengelberts ! You've accidentally committed this file as newsletter copy.json. Can you please revise (or resubmit), making sure to retain the original newsletter.json name? Thanks! (Please let me know if you get stuck and need help.) |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
ghost/i18n/locales/fr/newsletter.json (4)
10-10: Tone Verification for "Less like this"The updated translation "Contenu à éviter" introduces a nuance that differs from a more literal rendering. Please verify with the design or localization team that this phrasing is appropriate and clearly conveys the intended action within the UI context.
13-13: Nuance Check for "More like this"The revised translation "Contenu apprécié" shifts the tone compared to a literal translation. Confirm that this wording accurately reflects the intended meaning for triggering more recommended content and aligns with user expectations.
19-20: Review Upgrade MessagingThe translations for the upgrade messages—"Upgrade" as "Passez à l'abonnement payant" and "Upgrade to continue reading." as "Modifiez votre abonnement pour lire la suite."—change the prompt's tone. Please verify that this revised phrasing clearly communicates the desired call-to-action and is consistent with other parts of the application.
1-29: File Naming Consistency CheckThe PR objectives note an issue regarding file naming—specifically that the file was mistakenly committed as "newsletter copy.json" instead of "newsletter.json." In this review, please confirm that only the correctly named file ("newsletter.json") is included in the PR, and that any incorrectly named files have been renamed to adhere to the project's conventions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ghost/i18n/locales/fr/newsletter.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: cathysarisky
PR: TryGhost/Ghost#22007
File: ghost/i18n/locales/sl/newsletter.json:18-18
Timestamp: 2025-03-24T04:57:26.704Z
Learning: When reviewing translations of newsletter.json, check that the translations of status words (free/complimentary/paid/trialing) will form grammatically correct sentences when substituted into the message template. The status words should agree grammatically with the word "subscriber" in the target language.
🔇 Additional comments (2)
ghost/i18n/locales/fr/newsletter.json (2)
3-3: Translation Accuracy for Membership InvitationThe French translation for "Become a paid member of {site} to get access to all premium content." is clear and correctly preserves the dynamic placeholder.
22-22: Gender-Neutral Language and Placeholder ConsistencyThe change to a gender-neutral formulation in "Vous recevez ceci parce que vous êtes un·e abonné·e %%{status}%% de {site}." is well implemented. Ensure that the dynamic status placeholder (%%{status}%%) will integrate grammatically with this sentence when substituted, as per style guidelines.
|
Hey @cathysarisky, thanks for letting me know about this. I tried again, I hope I got this right! |
Almost! You need to delete the "copy" version, too. |
|
Great. Question: The "Upgrade" is going on a button in email. Is there a shorter way to say that? Here's how it looks in English, for context: |
|
True it's very long. I think "Modifiez votre abonnement" would work. Or, if that's still too long, "Changez d’abonnement" |
|
I'll defer to you on that! |
|
Great, thank you! I noticed a few errors linked with workflow runs. Anything I should do or modify? |
|
Nope. We just need a member of the dev team to run tests, it looks like.
…On Wed, Mar 26, 2025 at 9:43 AM gengelberts ***@***.***> wrote:
Great, thank you! I noticed a few errors linked with workflow runs.
Anything I should do or modify?
—
Reply to this email directly, view it on GitHub
<#22596 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKCXDVUXG4ZYIAOWSCBRUDL2WKVHTAVCNFSM6AAAAABZTFTHLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJUGQ2DOOJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: gengelberts]*gengelberts* left a comment (TryGhost/Ghost#22596)
<#22596 (comment)>
Great, thank you! I noticed a few errors linked with workflow runs.
Anything I should do or modify?
—
Reply to this email directly, view it on GitHub
<#22596 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKCXDVUXG4ZYIAOWSCBRUDL2WKVHTAVCNFSM6AAAAABZTFTHLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJUGQ2DOOJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
4 participants
This translates into French the CTA in email newsletters. A few minor changes were made to previously submitted translations to make them more accurate.